Summary: amfd: do not create compcsi of dependent csis if sponosr csi is unassigned [#1333] Review request for Trac Ticket(s): #1333 Peer Reviewer(s): Hans, Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 81b1a86db095f53be48715569f9444c2a33530de Author: [email protected] Date: Fri, 15 May 2015 08:53:37 +0530 amfd: do not create compcsi of dependent csis if sponosr csi is unassigned [#1333] A 2N application was up on both the controllers. Application contains 10 CSIs in a single SI with CSI dependency with multiple sponsors for some CSIs.While application was up on controllers, amfnd segfaults dDuring opensaf shutdown. For the CSI4, CStype is safVersion=4.0.0,safCSType=AmfDemo1 and for the rest of CSIs it is safVersion=4.0.0,safCSType=AmfDemo. Now CSI4 directly or indirectly acts as sponsor for CSI3, CSI6,CSI7,CSI8,CSI9 and CSI10. For CSI4 compcstype is not configured in the configuration. So AMF deletes compcsi for CSI3, but since there is chain of dependency, all other compcsi could not be deleted because logic of deleting COMPCSI (verify_csi_deps_and_delete_invalid_compcsi() in sgproc.c in #687) assumes that a SI (like SG) keeps the list_of_csi in the ascending order of csi rank. But CSIs in SI are arranged in descending order. Since some of the CSIs of higher rank remained unassigned, AMFND goes in loop to remove CSIs of higher rank when a CSIs of lower ranks are removed and it crashes while accessing some csi record for which remove_done() is already called. Patch ensures that irrespective of order of CSIs in SI, compcsi of dependent CSIs are deleted if any sponsor is unassigned. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sgproc.cc | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Testing Commands: ----------------- Tested with the imm.xml provided in the logs Testing, Expected Results: -------------------------- COMPCSI of dependents are not created if sponsor remains unassigned. Conditions of Submission: ------------------------- Ack from any reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
