Summary: amfd: do not spawn multiple threads for imm init[#2188] Review request for Trac Ticket(s): #2188 Peer Reviewer(s): AMF devs Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 4f0018d4813645d9cc7ff86cc59ae4969c205bf1 Author: Praveen Malviya <[email protected]> Date: Mon, 21 Nov 2016 15:19:30 +0530 amfd: do not spawn multiple threads for imm init[#2188] When AMFD receives BAD_HANDLE from IMM, it calls avd_imm_reinit_bg() to init with IMM in a separate thread. After this if again main thread tries to execute some job for IMM update, IMM will return BAD_HANDLE and AMFD will again call avd_imm_reinit_bg() to init with IMM. This can happen when AMFD tries to update IMM in job queues. Patch fixes this problem. Also if avd_saImmOiRtObjectUpdate_sync() fails with BAD_HANDLE, update will be pushed in jon queue to be updated later. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/imm.cc | 16 +++++++++++----- osaf/services/saf/amf/amfd/include/cb.h | 6 ++++++ osaf/services/saf/amf/amfd/main.cc | 2 ++ 3 files changed, 19 insertions(+), 5 deletions(-) Testing Commands: ----------------- Not tested. Patch is generated based on code analysis and logs. Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from Gary, Minh and Nagendra. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
