Summary:ntfd: process NTFA down event with high priority[#2206] Review request for Trac Ticket(s): #2206 Peer Reviewer(s): Minh, Canh. Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): ALL Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset b572a7e75adf949f256674a96cd62063897fa12c Author: Praveen Malviya <[email protected]> Date: Mon, 28 Nov 2016 14:35:22 +0530 ntfd: process NTFA down event with high priority[#2206] syslog gets flooded with following messages: Nov 24 12:38:00 SC-1 osafntfd[11771]: ER ntfs_mds_msg_send FAILED Nov 24 12:38:00 SC-1 osafntfd[11771]: ER ntfs_mds_msg_send to ntfa failed rc: 2 Nov 24 12:38:00 SC-1 osafntfd[11771]: ER ntfs_mds_msg_send FAILED In reported problem, an application like ntfsend is continuously sending notifications. Other subscriber application like ntfsubscribe with matching filter criteria is receiving those notifications. When subscriber suddenly exits, NTFS receives MDS_DOWN event for it. At the same time MDS is continuously delievering notifications sent by the sender app to the NTFS. NTFS posts internal events for both notification messages and NTFA down messages with HIGH and NORMAL priority respectively. Since priority of NTFA down event is NORMAL, NTFS processes down event relatively late compare to notificatin send messages. So notification send messages are processed before NTFA down events. While sending these notification to the subscriber, ncsmds_api returns failure because MDS has already cleared subscriber data like mds_dest. With this patch, NTFS will process NTFA down event with HIGH priority. Also LOG_ER is converted to LOG_WA or trace at some places. Complete diffstat: ------------------ osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 2 +- osaf/services/saf/ntfsv/ntfs/NtfClient.cc | 2 ++ osaf/services/saf/ntfsv/ntfs/NtfSubscription.cc | 7 +++++++ osaf/services/saf/ntfsv/ntfs/NtfSubscription.hh | 1 + osaf/services/saf/ntfsv/ntfs/ntfs_com.c | 3 ++- osaf/services/saf/ntfsv/ntfs/ntfs_mds.c | 4 ++-- 6 files changed, 15 insertions(+), 4 deletions(-) Testing Commands: ----------------- 1)Tested as per ticket description. 2)ntfstests Testing, Expected Results: -------------------------- 1)NTFS will report failure only once and that too as warning : Nov 28 12:44:59 SC-1 osafntfd[24769]: WA ntfs_mds_msg_send FAILED 2)ntftests pass. Conditions of Submission: ------------------------- Ack from reviewers. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
