Summary: mds: Correct timing issues in mdstest [#2798] Review request for Ticket(s): 2798 Peer Reviewer(s):Hans, Anders Pull request to: Hans, Anders Affected branch(es): develop, release Development branch: ticket-2798 Base revision: dac6b5bf582e581252f21d32b470f91d5629b867 Personal repository: git://git.code.sf.net/u/xhoalee/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 991afa77507212f681620782b35e5e7baa1b449b Author: Hoa Le <[email protected]> Date: Mon, 26 Mar 2018 11:45:57 +0700 mds: Correct timing issues in mdstest [#2798] In some bad thread scheduling situations, the API service request on the testing thread may be executed before the corresponding event being received on the MDS thread. This will lead to unexpected behavior of the service request and cause the failure of this test case. This patch adds a sleep period for mdstest to wait for the expected event being received on MDS thread before invoking the testing service request. Complete diffstat: ------------------ src/mds/apitest/mdstipc_api.c | 142 ++++++++++++++++++++++++++++++------------ 1 file changed, 102 insertions(+), 40 deletions(-) Testing Commands: ----------------- mdstest 4 10 mdstest 4 12 mdstest 5 1 mdstest 5 9 mdstest 10 1 mdstest 10 2 mdstest 14 5 mdstest 14 6 Testing, Expected Results: -------------------------- No failure appears. Conditions of Submission: ------------------------- ACK from reviewer. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
