On Tue, Jun 16, 2009 at 02:20:34PM +0200, Casper.Dik at Sun.COM wrote: > >If it can't detect ZFS on a disk then I don't think it is useful for > >OpenSolaris given that the root filesystem disk will be a ZFS disk. Not > >showing that ZFS is on a disk on Solaris/OpenSolaris system is actually > >dangerous as it could lead the user to assume the disk was empty.
+1, see also my suggestion of patching disktype to use libfstyp(3LIB) to deal with this. > But isn't it true that tools which modify disks will complain? That's true of *our* tools, but we're beginning to include lots of third party tools, like disktype, that most likely won't know how to find that a disk/partition/slice is in use. PSARC could, of course, reject integration of any tool that could modify a disk image without checking whether it's in use. But making disktype know about ZFS by making it use libfstyp seems like a very minor change to make to disktype. Nico --
