? 2008?11?13? 13:22, Erik Nordmark ??: > Huafeng Lu wrote: > >>> I don't understand why a new udp_cl_v6lastdst is needed since udp >>> already has a udp_v6lastdst field. >> >> The udp_v6lastdst field is used for Trusted Extension. To be safe, I >> don't want to reuse it, so the two new fields are introduced. > > That approach leads to exponentially increasing complexity over time.
After discussing with TX guys (cc'ed), we're re-using the udp_v6lastdst field. Only udp_lastdstport is added to udp_t. They're not mentioned in the updated PSARC material, though. ? 2008?11?13? 13:25, Erik Nordmark ??: > Honsing Cheng wrote: >> Currently the load balancing feature is limited to shared-IP zones. >> But we do believe that at some future point we would like to expand it >> to include exclusive-IP zones. So if it is relatively straight-forward >> to include the instance ID, we should pursue it. > > All you'd need is to include a extra argument to all the cl callbacks > (in the form of a netstackid_t or something similar.) > > I don't know if that would cause more incompatibilities than you are > already causing with this project. If it doesn't it might make sense to > include that argument now even though clustering would never inspect its > value until you decide to support exclusive-IP zones. Now all hooks are added with two arguments, 'netstackid_t stack_id' and 'void *args'. The latter can accommodate future changes to avoid changing the signatures again. We'll resubmit the PSARC materials soon. Thanks. -- Huafeng
