On 10/27/09 09:46 AM, Garrett D'Amore wrote: > Robs wrote: >> Hi. >> >> The supporting materials are here: >> >> http://sac.sfbay/arc/PSARC/2009/583/materials/ >> >> The DESCRIPTION field of the statgrab(3) man page gives a good >> overview of the package, including how it is implemented on Solaris: >> >> http://sac.sfbay/arc/PSARC/2009/583/materials/statgrab.3.txt > > Actually it doesn't mention anything other than some details about the > device tree. No mention of actual kstats is given at all. Right. Wasn't meant to cover kstats, just give an overview of the package. :) > >> >> kstat is indeed used. It is in cpu_stats.c and disk_stats.c, which >> can be seen here: >> >> >> /net/spidey.sfbay/builds/robs/usr/src/lib/libstatgrab/libstatgrab-0.16/src/libstatgrab >> >> > > Grunging through the source code to figure out the interfaces imported > is the job of the submitter, not of the reviewers. Understood.
However, the files in question are only 289 and 1026 lines in length, and this is certainly out of my area of expertise. More below... > Please go through, and find out which kstats are used (as well as any > other calls -- does it use network kstats, for example, or does it use > dladm? How does it identify devices?) The details should be in the > case materials presented here. If someone would help me offline with this, I'd really appreciate it. It'd be a good opportunity for me to learn, and will probably make this case go through a lot easier. Thanks! --Robs > > - Garrett >> >> Output from the two included commands are here: >> >> http://sac.sfbay/arc/PSARC/2009/583/materials/statgrab-out.txt >> http://sac.sfbay/arc/PSARC/2009/583/materials/saidar-out.png >> >> saidar is a curses-based tool, so I took a screenshot. >> >> NOTE: although spidey.sfbay shows-up in the output for both commands, >> the commands were run on another system... it's just that >> spidey.sfbay was being accessed. >> >> >> >> Regards, >> >> --Robs >> >> >> >> >> >> On 10/27/09 12:04 AM, Darren J Moffat wrote: >>> Nicolas Williams wrote: >>>> On Mon, Oct 26, 2009 at 09:32:03AM +0000, Darren J Moffat wrote: >>>>> What does it use on OpenSolaris ? Does it use kstat ? If so how >>>>> does it use them ? >>>>> >>>>> I can't see from this case what it consumes on Solaris and what >>>>> type of stats I'd expect to get. >>>> >>>> We had an earlier case that proposed enabling remote access to kstats, >>>> and that case had to be withdrawn on account of the instability of >>>> kstats. The same logic would have to apply here, but then, I suspect >>>> that it won't because: a) Linux familiarity rules will apply, b) my >>>> sense from the libstatgrab home page is that it uses only a subset of >>>> stats that are reasonably common across many operating systems, >>>> therefore likely to be stable in practice. >>> >>> I can't see from the case what they are and what OpenSolaris >>> interfaces are consumed to get them. >>> >>> The submitted case talks about Linux and BSD not not OpenSolaris. >>> >
