From db78deb8a03ccc08ff7a88e17cacb87604fac265 Mon Sep 17 00:00:00 2001 From: Adam Langley Date: Thu, 21 Feb 2013 17:11:55 -0500 Subject: [PATCH 05/11] dsa_crash Don't SEGFAULT when trying to export a public DSA key as a private key. --- crypto/dsa/dsa_ameth.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crypto/dsa/dsa_ameth.c b/crypto/dsa/dsa_ameth.c index 376156e..5f6e6f5 100644 --- a/crypto/dsa/dsa_ameth.c +++ b/crypto/dsa/dsa_ameth.c @@ -307,6 +307,12 @@ static int dsa_priv_encode(PKCS8_PRIV_KEY_INFO *p8, const EVP_PKEY *pkey) unsigned char *dp = NULL; int dplen; + if (!pkey->pkey.dsa->priv_key) + { + DSAerr(DSA_F_DSA_PRIV_ENCODE,DSA_R_MISSING_PARAMETERS); + goto err; + } + params = ASN1_STRING_new(); if (!params) -- 1.8.2.1