Hello community,
here is the log from the commit of package yast2-users for openSUSE:Factory
checked in at 2018-04-26 13:28:14
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-users (Old)
and /work/SRC/openSUSE:Factory/.yast2-users.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-users"
Thu Apr 26 13:28:14 2018 rev:210 rq:595583 version:4.0.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-users/yast2-users.changes 2018-04-07
20:50:54.555741265 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-users.new/yast2-users.changes
2018-04-26 13:28:16.113541574 +0200
@@ -1,0 +2,6 @@
+Fri Apr 6 13:34:48 UTC 2018 - igonzalezs...@suse.com
+
+- Do not crash if root user is not defined (bsc#1088183).
+- 4.0.5
+
+-------------------------------------------------------------------
Old:
----
yast2-users-4.0.4.tar.bz2
New:
----
yast2-users-4.0.5.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ yast2-users.spec ++++++
--- /var/tmp/diff_new_pack.9z3oEm/_old 2018-04-26 13:28:16.641522238 +0200
+++ /var/tmp/diff_new_pack.9z3oEm/_new 2018-04-26 13:28:16.645522091 +0200
@@ -17,7 +17,7 @@
Name: yast2-users
-Version: 4.0.4
+Version: 4.0.5
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
++++++ yast2-users-4.0.4.tar.bz2 -> yast2-users-4.0.5.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.0.4/package/yast2-users.changes
new/yast2-users-4.0.5/package/yast2-users.changes
--- old/yast2-users-4.0.4/package/yast2-users.changes 2018-03-27
10:21:14.000000000 +0200
+++ new/yast2-users-4.0.5/package/yast2-users.changes 2018-04-11
12:42:58.000000000 +0200
@@ -1,4 +1,10 @@
-------------------------------------------------------------------
+Fri Apr 6 13:34:48 UTC 2018 - igonzalezs...@suse.com
+
+- Do not crash if root user is not defined (bsc#1088183).
+- 4.0.5
+
+-------------------------------------------------------------------
Fri Mar 23 14:20:59 UTC 2018 - jreidin...@suse.com
- Fix import of RootPassword if user is specified in autoyast
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.0.4/package/yast2-users.spec
new/yast2-users-4.0.5/package/yast2-users.spec
--- old/yast2-users-4.0.4/package/yast2-users.spec 2018-03-27
10:21:14.000000000 +0200
+++ new/yast2-users-4.0.5/package/yast2-users.spec 2018-04-11
12:42:58.000000000 +0200
@@ -17,7 +17,7 @@
Name: yast2-users
-Version: 4.0.4
+Version: 4.0.5
Release: 0
BuildRoot: %{_tmppath}/%{name}-%{version}-build
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.0.4/src/modules/Users.pm
new/yast2-users-4.0.5/src/modules/Users.pm
--- old/yast2-users-4.0.4/src/modules/Users.pm 2018-03-27 10:21:14.000000000
+0200
+++ new/yast2-users-4.0.5/src/modules/Users.pm 2018-04-11 12:42:58.000000000
+0200
@@ -4024,6 +4024,7 @@
}
}
+BEGIN { $TYPEINFO{WriteAuthorizedKeys} = ["function", "boolean"]; }
sub WriteAuthorizedKeys {
foreach my $username (keys %{$modified_users{"local"}}) {
my %user = %{$modified_users{"local"}{$username}};
@@ -4033,11 +4034,16 @@
}
}
- # Write root authorized keys(bsc#1066342)
- my %root_user = %{$modified_users{"system"}{"root"}};
- if ($root_user{"modified"} eq "imported") {
- SSHAuthorizedKeys->write_keys($root_user{"homeDirectory"});
+ # Do not crash if 'root' is undefined (bsc#1088183)
+ if (defined($modified_users{"system"}{"root"})) {
+ # Write root authorized keys(bsc#1066342)
+ my %root_user = %{$modified_users{"system"}{"root"}};
+ if ($root_user{"modified"} eq "imported") {
+ SSHAuthorizedKeys->write_keys($root_user{"homeDirectory"});
+ }
}
+
+ return 1;
}
##------------------------------------
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.0.4/test/Makefile.am
new/yast2-users-4.0.5/test/Makefile.am
--- old/yast2-users-4.0.4/test/Makefile.am 2018-03-27 10:21:14.000000000
+0200
+++ new/yast2-users-4.0.5/test/Makefile.am 2018-04-11 12:42:58.000000000
+0200
@@ -6,6 +6,7 @@
lib/users/users_database_test.rb \
dialogs_test.rb \
ssh_authorized_keys_test.rb \
+ users_test.rb \
users_auto_test.rb \
users_finish_test.rb \
widgets_test.rb
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.0.4/test/users_auto_test.rb
new/yast2-users-4.0.5/test/users_auto_test.rb
--- old/yast2-users-4.0.4/test/users_auto_test.rb 2018-03-27
10:21:14.000000000 +0200
+++ new/yast2-users-4.0.5/test/users_auto_test.rb 2018-04-11
12:42:58.000000000 +0200
@@ -24,7 +24,6 @@
end
describe "#AutoYaST" do
-
context "Import" do
before do
allow(Yast::WFM).to
receive(:Args).with(no_args).and_return([func,users])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/yast2-users-4.0.4/test/users_test.rb
new/yast2-users-4.0.5/test/users_test.rb
--- old/yast2-users-4.0.4/test/users_test.rb 1970-01-01 01:00:00.000000000
+0100
+++ new/yast2-users-4.0.5/test/users_test.rb 2018-04-11 12:42:58.000000000
+0200
@@ -0,0 +1,17 @@
+#!/usr/bin/env rspec
+
+require_relative "test_helper"
+
+Yast.import "Users"
+
+describe "Users" do
+ subject(:users) { Yast::Users }
+
+ describe "#WriteAuthorizedKeys" do
+ context "when no user is defined" do
+ it "returns true" do
+ expect(users.WriteAuthorizedKeys).to eq(true)
+ end
+ end
+ end
+end
