Boost,.Regex is fine by me too.
Bård ________________________________________ From: Opm [opm-boun...@opm-project.org] on behalf of Alf Birger Rustad [a...@statoil.com] Sent: 28 June 2014 23:55 To: Andreas Lauser Cc: opm@opm-project.org Subject: Re: [OPM] Require Boost:regex I believe Boost is the best solution here. We already use Boost to remedy the shortcomings of the gcc versions we need to support, and regex provides necessary functionality. Cheers, Alf Andreas Lauser <a...@poware.org>: Hi, Some remarks from the offender (i.e. me) seem to be appropriate. I've chosen boost::regex because: - it is the library which got graduated to std:: in c++-2011, so that the code changes should be minimal once GCC 4.9 is the minimum supported compiler version of OPM - we already use quite a few boost libraries, so adding another one to the prerequisites seemed natural - I did not know about regex.h (*booohhh*) have a nice (remaining) weekend Andreas On Saturday, June 28, 2014 15:40:55 Joakim Hove wrote: > Hello; > > In the PR: https://github.com/OPM/opm-parser/pull/249 Andreas has > implemented support for regex matching of keywords in the deck. We need > this functionality, and modulo minor fixes I intend to merge this PR. > However, the PR uses Boost::regex; so going with it as it is now will > introduce a Boost::regex dependeny through the whole stack. As I see it > there are two possibilities: > > > 1. Take the PR as is and accept the Boost::regex dependency - that > might be perfectly OK? > > 2. Use C/Posix regex.h. > > Any opinions? Whatever choice we make we should preferably switch to > std::regex when we switch to a sufficiently new g++ compiler. > > Joakim -- Notice: "String" and "Thread" are the same thing to non-computing people. — Programming.com ------------------------------------------------------------------- The information contained in this message may be CONFIDENTIAL and is intended for the addressee only. Any unauthorised use, dissemination of the information or copying of this message is prohibited. If you are not the addressee, please notify the sender immediately by return e-mail and delete this message. Thank you _______________________________________________ Opm mailing list Opm@opm-project.org http://www.opm-project.org/mailman/listinfo/opm _______________________________________________ Opm mailing list Opm@opm-project.org http://www.opm-project.org/mailman/listinfo/opm
