On Thu, Apr 06, 2017 at 08:37:34AM -0700, Ben Pfaff wrote:
> On Mon, Mar 27, 2017 at 02:56:09PM -0400, Lance Richardson wrote:
> > Keep track of authenticated ID for stream peer. For SSL connections,
> > the authenticated ID is the CN (Common Name) field from the peer's
> > SSL certificate.
> >
> > Signed-off-by: Lance Richardson <lrich...@redhat.com>
>
> Not all the new functions here follow the OVS convention that the
> function name should be at the beginning of a line.
>
> It looks like the convention here is that the peer id is the common
> name, except that if the common name contains "id:..." then that and
> everything after it is not part of the peer id. Probably, this
> convention should be documented somewhere, although that might only come
> with a later patch that actually makes this feature user-visible (I
> haven't read ahead yet).
Oh, and I get build failures because:
../lib/stream-ssl.c:452:24: error: 'ASN1_STRING_data' is deprecated
[-Werror,-Wdeprecated-declarations]
/usr/include/openssl/asn1.h:553:35: note: 'ASN1_STRING_data' has been
explicitly marked deprecated here
/usr/include/i386-linux-gnu/openssl/opensslconf.h:130:53: note: expanded
from macro 'DEPRECATEDIN_1_1_0'
/usr/include/i386-linux-gnu/openssl/opensslconf.h:105:35: note: expanded
from macro 'DECLARE_DEPRECATED'
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
