On Thu, Jul 06, 2017 at 09:48:58PM +0000, Darrell Ball wrote:
>
>
> On 7/6/17, 2:36 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
> <ovs-dev-boun...@openvswitch.org on behalf of b...@ovn.org> wrote:
>
> Can someone review this please?
>
> On Mon, May 01, 2017 at 10:30:27AM -0700, Ben Pfaff wrote:
> > Hemant, does this fix the problem you reported?
> >
> > On Fri, Apr 14, 2017 at 09:14:55PM -0700, Ben Pfaff wrote:
> > > The check for rte_config.h in acinclude.m4 used AC_CHECK_FILE, but
> this
> > > macro is intended to check for a file on the host system, not the
> build
> > > system, which means that it fails unconditionally in a
> cross-compilation
> > > environment. However, the intended check here is for a header file,
> > > which is part of the build system. To check for part of the build
> system,
> > > we can just use "test", so this commit makes that change.
> > >
> > > Reported-by: Hemant Agrawal <hemant.agra...@nxp.com>
> > > Reported-at:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_pipermail_ovs-2Ddev_2017-2DMarch_329994.html&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=9SEip3J9loq15hpoutcyARnoiI9CS9RRVfT0oFE5C8k&s=dOQYeMGyHRUBxuPzkJLkr2oUHFTObc-qjwZhHCDFTrU&e=
>
> > > Signed-off-by: Ben Pfaff <b...@ovn.org>
> > > ---
> > > acinclude.m4 | 7 ++++---
> > > 1 file changed, 4 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/acinclude.m4 b/acinclude.m4
> > > index 744d8f89525c..842469455914 100644
> > > --- a/acinclude.m4
> > > +++ b/acinclude.m4
> > > @@ -180,9 +180,10 @@ AC_DEFUN([OVS_CHECK_DPDK], [
> > > DPDK_INCLUDE="$with_dpdk/include"
> > > # If 'with_dpdk' is passed install directory, point to
> headers
> > > # installed in $DESTDIR/$prefix/include/dpdk
> > > - AC_CHECK_FILE([$DPDK_INCLUDE/rte_config.h], [],
> > > -
> [AC_CHECK_FILE([$DPDK_INCLUDE/dpdk/rte_config.h],
> > > -
> [DPDK_INCLUDE=$DPDK_INCLUDE/dpdk], [])])
> > > + if test ! -e "$DPDK_INCLUDE/rte_config.h" && \
> > > + test -e "$DPDK_INCLUDE/dpdk/rte_config.h"; then
> > > + DPDK_INCLUDE=$DPDK_INCLUDE/dpdk/rte_config.h
>
> Did you mean
> DPDK_INCLUDE=$DPDK_INCLUDE/dpdk
> rather than
> DPDK_INCLUDE=$DPDK_INCLUDE/dpdk/rte_config.h
> ?
Oops, you're right. Fixed in v2:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335079.html
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
