On Mon, Jun 24, 2024 at 11:52 AM Ilya Maximets <i.maxim...@ovn.org> wrote:
> On 6/24/24 11:24, Dumitru Ceara wrote: > > On 6/24/24 11:00, Ales Musil wrote: > >> The pip upgrade in Ubuntu started to fail because of missing > >> RECORD file. Use the --user argument which avoids this error and > >> allows pip to upgrade itself. > >> > >> ERROR: Cannot uninstall pip 24.0, RECORD file not found. > >> Hint: The package was installed by debian. > >> > >> Suggested-by: Ilya Maximets <i.maxim...@ovn.org> > >> Signed-off-by: Ales Musil <amu...@redhat.com> > >> --- > > > > Thanks, Ales, for fixing the CI! > > > >> utilities/containers/ubuntu/Dockerfile | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/utilities/containers/ubuntu/Dockerfile > b/utilities/containers/ubuntu/Dockerfile > >> index ce7ce16c6..0e71b1a02 100755 > >> --- a/utilities/containers/ubuntu/Dockerfile > >> +++ b/utilities/containers/ubuntu/Dockerfile > >> @@ -80,7 +80,7 @@ COPY $CONTAINERS_PATH/py-requirements.txt > /tmp/py-requirements.txt > >> ENV PIP_BREAK_SYSTEM_PACKAGES 1 > >> > >> # Update and install pip dependencies > >> -RUN python3 -m pip install --upgrade pip \ > >> +RUN python3 -m pip install --upgrade --user pip \ > >> && \ > >> python3 -m pip install wheel \ > >> && \ > > > > I think for consistency we should do the same thing for the Fedora > > dockerfile. However, you're changing all that in: > > > > https://patchwork.ozlabs.org/project/ovn/list/?series=411795&state=* > > > > I think it's probably better to do all that at once (to avoid having to > > rebase different series) and submit a v2 of the series that moves the > > DPDK build into the container. That series could have as first patch > > the --user change for both dockerfiles. > > > > What do you think? > > This also should be done for all 'pip install' calls, not only the > upgrade of a pip itself. > > Best regards, Ilya Maximets. > > Sure sounds good, I'll prepare v2 of the DPDK series with this fix included. Thanks, Ales -- Ales Musil Senior Software Engineer - OVN Core Red Hat EMEA <https://www.redhat.com> amu...@redhat.com <https://red.ht/sig> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
