smengcl commented on a change in pull request #1401:
URL: https://github.com/apache/hadoop-ozone/pull/1401#discussion_r484586039
##########
File path: hadoop-ozone/dist/src/shell/ozone/ozone
##########
@@ -105,8 +105,9 @@ function ozonecmd_case
# Corresponding Ratis issue
https://issues.apache.org/jira/browse/RATIS-534.
# TODO: Fix the problem related to netty resource leak detector throwing
# exception as mentioned in HDDS-3812
-
HDDS_DN_OPTS="-Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false
-Dorg.apache.ratis.thirdparty.io.netty.leakDetection.level=disabled
-Dlog4j.configurationFile=${HADOOP_CONF_DIR}/dn-audit-log4j2.properties
${HDDS_DN_OPTS}"
- HADOOP_OPTS="${HADOOP_OPTS} ${HDDS_DN_OPTS}"
+ hadoop_deprecate_envvar HDDS_DN_OPTS OZONE_DATANODE_OPTS
+
OZONE_DATANODE_OPTS="-Dorg.apache.ratis.thirdparty.io.netty.allocator.useCacheForAllThreads=false
-Dorg.apache.ratis.thirdparty.io.netty.leakDetection.level=disabled
-Dlog4j.configurationFile=${HADOOP_CONF_DIR}/dn-audit-log4j2.properties
${OZONE_DATANODE_OPTS}"
+ HADOOP_OPTS="${HADOOP_OPTS} ${OZONE_DATANODE_OPTS}"
Review comment:
Yes looks like `HADOOP_OPTS="${HADOOP_OPTS} ${OZONE_DATANODE_OPTS}"` is
redundant with `hadoop_subcommand_opts` since we are aligning the OPTS names.
Good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
