ChenSammi commented on a change in pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#discussion_r495777131



##########
File path: 
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -334,15 +329,11 @@ public boolean setVolumeOwner(String volumeName, String 
owner)
   }
 
   @Override
-  public void setVolumeQuota(String volumeName, long quotaInCounts,
-      long quotaInBytes) throws IOException {
+  public void setVolumeQuota(String volumeName, long quotaInBytes,
+      long quotaInCounts) throws IOException {

Review comment:
       Can we align the  quotaInBytes and quotaInCounts order in setVolumeQuota 
and setBucketQuota?  In another words, no need for the code change here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org

Reply via email to