https://bugzilla.redhat.com/show_bug.cgi?id=1250178
Iwicki Artur <iwicki.ar...@svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |iwicki.ar...@svgames.pl
--- Comment #3 from Iwicki Artur <iwicki.ar...@svgames.pl> ---
I am not a packager, so this is not an official review.
> Release: 0%{?dist}
The release tag should start with 1, not 0.
https://fedoraproject.org/wiki/Packaging:Versioning#Simple_versioning
> cp -p %{SOURCE1} .
> install -D -m 0644 ...
The install command lacks the -p switch.
> License: GPLv2
Licence file doesn't appear in the sources and is not included in the %files
section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
