>>>>> "BD" == Brent Dax <[EMAIL PROTECTED]> writes:

  BD> static INTVAL
  BD> Parrot_scalar_get_integer(struct Parrot_Interp* interpreter, PMC* pmc) {
  BD>   PSD* sd=(PSD*)pmc->data;

  BD>   if(FLAG_pmc_iok_TEST(pmc)) {
  BD>           return sd->intdata;
  BD>   }

  BD>   FLAG_pmc_iok_SET(pmc);

  BD>   if(FLAG_pmc_nok_TEST(pmc)) {
  BD>           return sd->intdata=(INTVAL) sd->numdata;
  BD>   }
  BD>   else if(FLAG_pmc_sok_TEST(pmc)) {

skip the else clauses after a return.

        PSD* sd=(PSD*)pmc->data;

        if (FLAG_pmc_iok_TEST(pmc)) {
                return sd->intdata;
        }

        FLAG_pmc_iok_SET(pmc);

        if (FLAG_pmc_nok_TEST(pmc)) {
                return sd->intdata = (INTVAL) sd->numdata;
        }

        if (FLAG_pmc_sok_TEST(pmc)) {
                return sd->intdata = Parrot_string_to_int(sd->strdata);
        }
        
        if (FLAG_pmc_rok_TEST(pmc)) {
                /* assuming we want to handle references this way */
                return sd->intdata =
                         sd->refdata->vtable->get_integer(interpreter,
                                                        sd->refdata);
        }

        Parrot_croak("PANIC: Parrot_scalar_get_integer");
        return 0;

that is starting to look okay now. some extra horizontal white space
helps too IMO.


-- 
Uri Guttman  ------  [EMAIL PROTECTED]  -------- http://www.stemsystems.com
-- Stem is an Open Source Network Development Toolkit and Application Suite -
----- Stem and Perl Development, Systems Architecture, Design and Coding ----
Search or Offer Perl Jobs  ----------------------------  http://jobs.perl.org

Reply via email to