# New Ticket Created by Mattia Barbon
# Please include the string: [perl #24931]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=24931 >
Hello,
the important part is the change to config/init/hints/mswin32.pl,
without which the build fails.
The other changes are just warning fixes.
Tested with GCC 3.3 (and 3.2 and 2.95) with GNU make 3.79
Regards
Mattia
? t/pmc/coroutine_4.imc
Index: config/gen/platform/win32.h
===================================================================
RCS file: /cvs/public/parrot/config/gen/platform/win32.h,v
retrieving revision 1.9
diff -u -2 -r1.9 win32.h
--- config/gen/platform/win32.h 25 Nov 2003 16:23:06 -0000 1.9
+++ config/gen/platform/win32.h 17 Jan 2004 13:53:25 -0000
@@ -21,4 +21,5 @@
void Parrot_platform_init_code(void);
+#ifdef _MSC_VER
/* These disable certain Level 4 Warnings */
#pragma warning( disable: 4100 ) /* disables 'unreferenced formal parameter'
@@ -29,4 +30,6 @@
#pragma warning( disable: 4505 ) /* disables 'unreferenced local function has
* been removed' warnings in header files */
+#endif /* defined(_MSC_VER) */
+
/*
** Miscellaneous:
Index: config/init/hints/mswin32.pl
===================================================================
RCS file: /cvs/public/parrot/config/init/hints/mswin32.pl,v
retrieving revision 1.17
diff -u -2 -r1.17 mswin32.pl
--- config/init/hints/mswin32.pl 22 Nov 2003 09:55:45 -0000 1.17
+++ config/init/hints/mswin32.pl 17 Jan 2004 13:53:26 -0000
@@ -103,5 +103,5 @@
link => 'gcc',
libs => $libs,
- slash => '\\',
+ slash => '/',
ar => 'ar',
);
Index: src/hash.c
===================================================================
RCS file: /cvs/public/parrot/src/hash.c,v
retrieving revision 1.68
diff -u -2 -r1.68 hash.c
--- src/hash.c 15 Jan 2004 21:50:24 -0000 1.68
+++ src/hash.c 17 Jan 2004 13:53:41 -0000
@@ -739,4 +739,5 @@
internal_exception(-1, "hash corruption: type = %d\n",
hash->entry_type);
+ valtmp = NULL; /* avoid warning */
};
hash_put(interp, *dest, key, valtmp);
Index: src/spf_render.c
===================================================================
RCS file: /cvs/public/parrot/src/spf_render.c,v
retrieving revision 1.28
diff -u -2 -r1.28 spf_render.c
--- src/spf_render.c 6 Jan 2004 17:13:32 -0000 1.28
+++ src/spf_render.c 17 Jan 2004 13:53:44 -0000
@@ -604,10 +604,10 @@
if(tolower(ch) == 'g') {
- UINTVAL i;
- for(i=0; i < strlen(tc); i++) {
- if(tolower(tc[i]) == 'e' &&
- (tc[i+1] == '+' || tc[i+1] == '-')) {
- tc[i+2]='\0';
- strcat(tc, &(tc[i+3]));
+ UINTVAL j;
+ for(j=0; j < strlen(tc); j++) {
+ if(tolower(tc[j]) == 'e' &&
+ (tc[j+1] == '+' || tc[j+1] == '-')) {
+ tc[j+2]='\0';
+ strcat(tc, &(tc[j+3]));
}
}
Index: src/thread.c
===================================================================
RCS file: /cvs/public/parrot/src/thread.c,v
retrieving revision 1.15
diff -u -2 -r1.15 thread.c
--- src/thread.c 14 Jan 2004 13:10:13 -0000 1.15
+++ src/thread.c 17 Jan 2004 13:53:45 -0000
@@ -224,5 +224,5 @@
if (interpreter->thread_data->state == THREAD_STATE_JOINABLE ||
interpreter->thread_data->state == THREAD_STATE_FINISHED) {
- void *retval;
+ void *retval = NULL;
interpreter->thread_data->state |= THREAD_STATE_JOINED;
UNLOCK(interpreter_array_mutex);
