On Jan 13, 2007, at 9:59 AM, Patrick R. Michaud wrote:
As part of bugday Bernhard fixed up a couple of japh tests
(examples/japh/) that were using the now obsolete 'pack'
opcode. This helps with RT #37068, but still doesn't
resolve it entirely as there are other japh examples that
don't work.
In looking through the remaining japh examples, most of them
seem to have been obsoleted by changes to Parrot -- especially
w.r.t. calling conventions and namespaces. Could we perhaps
eliminate these obsolete examples as well?
Absolutely. I'd say anything JAPH that fails anywhere, kill it.
If it's supposed to testing a feature, let's just test that feature
explicitly.
Here's the state of the programs in examples/japh/ as of r16588:
japh1.pasm: deleted
japh2.pasm: deleted
japh3.pasm: ok (uses substr hackery)
japh4.pasm:
Fails with 'attempt to access code outside of current code
segment'.
This particular example creates a __get_string vtable method
for a 'Japh' class, but does so using .pcc_sub . The 'todo'
marker on the test indicates that the 'namespace has changed'
(I presume this means that namespace implementations are different
now.)
japh5.pasm: ok (overloads __set_string_keyed)
japh6.pasm: ok (overloads __get_string_keyed)
japh7.pasm: ok (traps an error and fiddles with opcode number)
japh8.pasm: Fails on 64-bit platforms.
japh9.pasm:
Fails because it relies on old Parrot calling conventions
whereby the return continuation would be stored in P1.
(The todo message reads "P1 is no longer special".)
japh10.pasm:
Fails with "Method 'thread3' not found".
japh11.pasm:
Fails with "no label offset for '_init'". I'm guessing
this is because the _init label comes after an empty
".namespace" directive and .namespace handling has changed
somewhat.
japh12.pasm: deleted in r16588
japh13.pasm:
Fails with 'invoke opcode not found'.
japh14.pasm:
Fails with 'invoke_p opcode not found'.
japh15.pasm:
Fails with 'invokecc opcode not found'.
japh16.pasm:
Uses the deprecated 'compile' opcode, as well as an external
shared object file from examples/compilers/ (which also doesn't
compile on my system).
japh17.pasm:
Fails with 'invoke_p opcode not found'.
Pm
--
Will "Coke" Coleda
[EMAIL PROTECTED]
