Hi,

Some warnings are being emitted by both msvc and gcc, which I think were
caused by this patch.

msvc:

[10:15] < particle> src\ops\core_ops.c(14190) : warning C4047:
'initializing' : 'op_func_t' differs
[10:15] < particle> in levels of indirection from 'op_func_t * '

gcc:

src/ops/core_ops.c:14190: warning: initialization from incompatible
pointer type

The line in question is trying to NULL-terminate an array of
op_func_t's.  The issue is that op_func_t is *already* a pointer type,
and this patch changed a "function pointer" into a "pointer to a
function pointer".

Here's how op_func_t is declared:

typedef opcode_t *(*op_func_t)(opcode_t *, Interp *);


Steve, does the patch you submitted fix anything for you?  (In other
words, will it break anything to revert this?)

Mark

Reply via email to