# New Ticket Created by Jerry Gay # Please include the string: [perl #42959] # in the subject line of all future correspondence about this issue. # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=42959 >
On 5/15/07, chromatic <[EMAIL PROTECTED]> wrote: > On Tuesday 15 May 2007 09:08:47 [EMAIL PROTECTED] wrote: > > > Log: > > eliminate some compiler warnings > > ~ all tests pass > > > > Modified: trunk/src/debug.c > > =========================================================================== > >=== --- trunk/src/debug.c(original) > > +++ trunk/src/debug.cTue May 15 09:08:45 2007 > > @@ -1983,8 +1983,10 @@ > > PDB_eval(Interp *interp, const char *command) > > { > > opcode_t *run; > > +#if 0 > > PackFile *eval_pf; > > PackFile_ByteCode *old_cs; > > +#endif > > The UNUSED() macro seems to be slightly more descriptive. If you have an > update soon that'll use those variables, this is fine for now, but I hate to > have more #if 0 ... #endif pairs in the source without explanation why > they're there. > > -- c > just below this code in that file, there's an #if 0 block i'm not responsible for. there vars were used only in that block. i wrapped them in #if 0 simply to remove the warning, while keeping the intent of the code the same. i agree that #if 0 is bad practice in general. i didn't have tuits at the time to perform a code review on this block--i just corrected an oversight by the original coder. i've forwarded this to rt, so somebody can clean up this code properly. ~jerry