On Friday 14 March 2008 16:11:54 [EMAIL PROTECTED] wrote:

> Modified:
>    trunk/src/embed.c
>
> Log:
> * src/embed.c:
>    + (Parrot_readbc):  fread returns size_t, so change the decalaration
>      of read_result to match.

As size_t is always positive, the conditional on line 431 can never be true:

        if (read_result < 0) {
            PIO_eprintf(interp,
                    "Parrot VM: Problem reading packfile from PIO.\n");
            return NULL;
        }

My man page suggests that fread returns either a short item count or zero on 
error, never a negative value, so this conditional was probably never 
correct.

-- c

Reply via email to