On Sun Mar 16 19:28:53 2008, kraai wrote: > Howdy, > > t/examples/pasm.t fails because examples/pasm/fact.pasm now outputs 30 > factorials, whereas the test case only expects it to output 6.
I was just at the point of filing a separate bug report on the failure in t/examples/pasm.t when I saw your post. I applied your patch, but got inconsistent results with it between Darwin and Linux. On Darwin, test #4 (the factorial test) once again passed. But on Linux, this was my result: $ prove -v t/examples/pasm.tt/examples/pasm...... 1..6 ok 1 - examples/pasm/queens.pasm ok 2 - examples/pasm/hello.pasm ok 3 - examples/pasm/stack.pasm not ok 4 - examples/pasm/fact.pasm # Failed test 'examples/pasm/fact.pasm' # at t/examples/pasm.t line 117. # Exited with error code: 1 # Received: # fact of 0 is: 1 # fact of 1 is: 1 # fact of 2 is: 2 # fact of 3 is: 6 # fact of 4 is: 24 # fact of 5 is: 120 # fact of 6 is: 720 # fact of 7 is: 5040 # fact of 8 is: 40320 # fact of 9 is: 362880 # fact of 10 is: 3628800 # fact of 11 is: 39916800 # fact of 12 is: 479001600 # fact of 13 is: no bigint lib loaded # current instr.: '(null)' pc 42 (/home/jimk/work/parrot/t/examples/pasm_4.pasm:54) # # Expected: # fact of 0 is: 1 # fact of 1 is: 1 # fact of 2 is: 2 # fact of 3 is: 6 # fact of 4 is: 24 # fact of 5 is: 120 # fact of 6 is: 720 # fact of 7 is: 5040 # fact of 8 is: 40320 # fact of 9 is: 362880 # fact of 10 is: 3628800 # fact of 11 is: 39916800 # fact of 12 is: 479001600 # fact of 13 is: 6227020800 # fact of 14 is: 87178291200 # fact of 15 is: 1307674368000 # fact of 16 is: 20922789888000 # fact of 17 is: 355687428096000 # fact of 18 is: 6402373705728000 # fact of 19 is: 121645100408832000 # fact of 20 is: 2432902008176640000 # fact of 21 is: 51090942171709440000 # fact of 22 is: 1124000727777607680000 # fact of 23 is: 25852016738884976640000 # fact of 24 is: 620448401733239439360000 # fact of 25 is: 15511210043330985984000000 # fact of 26 is: 403291461126605635584000000 # fact of 27 is: 10888869450418352160768000000 # fact of 28 is: 304888344611713860501504000000 # fact of 29 is: 8841761993739701954543616000000 # fact of 30 is: 265252859812191058636308480000000 # ok 5 - examples/pasm/xml_parser.pasm not ok 6 - nanoforth2.pasm # TODO nanoforth2.pasm not testable yet # Failed (TODO) test 'nanoforth2.pasm' # at t/examples/pasm.t line 124. # Looks like you failed 1 test of 6. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests Test Summary Report ------------------- t/examples/pasm.t (Wstat: 256 Tests: 6 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=6, 3 wallclock secs ( 0.00 usr 0.00 sys + 0.35 cusr 0.03 csys = 0.38 CPU) Result: FAIL To the best of my memory, I have never installed a bigint library on this Linux box; I'm not quite sure what that is. But, in any case, shouldn't the test be smart enough to do the right thing in either case (having or not having bigint)? > t/perl/Parrot_IO.t fails because it skips the Subversion-specific > tests only when run in a Subversion working copy. The attached patch > fixes both problems. > Perhaps because I'm usually working in a Subversion working copy, I haven't experienced this error. So I did not test out this patch.