On Fri Mar 28 07:07:37 2008, coke wrote: > > > perlcritic is passing all tests at the moment. Added back to the set of > default tests run in r26591. Closing ticket.
I'm re-opening this ticket due to problems I have experienced since r26591 with t/codingstd/perlcritic.t on two different OSes. t/codingstd/perlcritic.t is failing to detect the presence of a sufficiently recent (>=1.03) Perl::Critic on *both* my ppc-darwin (OS X 10.4) iBook and my 386-linux-debian server. Moreover, on darwin the failure to detect Perl::Critic is generating noisy warnings. Linux: $ perldoc -m Perl::Critic ############################################################################## # $URL: http://perlcritic.tigris.org/svn/perlcritic/branches/Perl-Critic-1. 073/lib/Perl/Critic.pm $ # $Date: 2007-09-15 09:36:06 -0500 (Sat, 15 Sep 2007) $ from 'make test' log at r26707 (2008-04-02): t/codingstd/pccmethod_deps.....................ok t/codingstd/perlcritic.........................skipped: Perl::Critic not installed t/codingstd/pir_code_coda......................ok Darwin: $ perldoc -m Perl::Critic ############################################################################## # $URL: http://perlcritic.tigris.org/svn/perlcritic/tags/Perl-Critic-1.053/ lib/Perl/Critic.pm $ from 'make test' log r26689 on 2008-04-01: t/codingstd/perlcritic.........................Couldn't require Perl::Critic::Policy::CodeLayout::RequireConsistentNewlines : Can't locate Clone.pm in @INC (@INC contains: [skip @INC listings] skipped: Perl::Critic not installed On Darwin, searching for the nonfeasant Clone.pm, I get: [perl6] 568 $ locate Clone.pm /usr/local/lib/perl5/site_perl/5.8.8/darwin-2level/Clone.pm ... but I find no reference to Clone.pm in the relevant Perl::Critic module. $ grep -n Clone /usr/local/lib/perl5/site_perl/5.8.8/Perl/Critic/Policy/CodeLayout/RequireConsi stentNewlines.pm ... nada. Perhaps t/codingstd/perlcritic.t is not yet really ready for prime time? kid51
