# New Ticket Created by  James Keenan 
# Please include the string:  [perl #53094]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=53094 >


This morning I noticed that the following change had been made to 
config/auto/perldoc.pm:

$ svn diff -r {2008-04-19} config/auto/perldoc.pm
Index: config/auto/perldoc.pm
===================================================================
--- config/auto/perldoc.pm      (revision 27027)
+++ config/auto/perldoc.pm      (working copy)
@@ -36,7 +36,7 @@
  sub runstep {
      my ( $self, $conf ) = @_;

-    my $cmd = $conf->data->get_p5('scriptdirexp') . q{/perldoc};
+    my $cmd = q{perldoc};
      my $tmpfile = q{c99da7c4.tmp};
      my $content = capture_output("$cmd -ud $tmpfile perldoc") || undef;


The log message associated with this commit presented its rationale:

------------------------------------------------------------------------
r27056 | fperrad | 2008-04-20 05:57:41 -0400 (Sun, 20 Apr 2008) | 3 lines

[perldoc]
- fix with strawberry Perl 5.10.0


However, IMO it would have been preferable to present this issue in an 
RT [BUG] ticket first.  As it stands, I have no idea as to the 
particular problem which François found with this config step on 
Strawberry Perl.  More importantly, the patch essentially undoes this 
patch which Mark Glines committed a month ago:


------------------------------------------------------------------------
r26513 | infinoid | 2008-03-21 16:24:58 -0400 (Fri, 21 Mar 2008) | 9 lines

[config] perldoc check should use $Config{scriptdirexp}, not 
$Config{scriptdir}. The "scriptdir" value from p5 is sometimes 
interpreted in strange ways, but the "scriptdirexp" value is expanded at 
compile-time, so it's guaranteed to be sane.

Grep perl-5.10.0's perldelta.pod for "Relocatable installations" for 
details. This was preventing "perldoc" from being detected properly on a 
local install of perl.  wolverian++ for reporting it.



I don't know the entire history of this config step or of Parrot's 
configuration in general.  But I do know that we draw many of our 
configuration settings from the Perl 5 Config module found on the box 
attempting configuration of Parrot.  I also know that we have developers 
who have multiple Perls on their machine, hence have multiple 'perldoc's 
on their machine.  In the past, at least, it has been important to know 
which 'perldoc' is being referenced.

So, while this fix might be good for Strawberry Perl, there's a good 
chance it will break someone else's Parrot configuration.

François, can you present the problem in this ticket?

Mark, can you evaluate impact?

Thank you very much.

kid51

Reply via email to