On Thursday 21 August 2008 15:08:22 [EMAIL PROTECTED] wrote: Mostly minor codingstd nits.
> Modified: > branches/pdd27mmd/src/pmc/multisub.pmc > > Log: > [pdd09gc] add basic (and probably wrong) implementations for > MultiSub:get_pmc_keyed and MultiSub:get_pmc_keyed_string > > --- branches/pdd27mmd/src/pmc/multisub.pmc (original) > +++ branches/pdd27mmd/src/pmc/multisub.pmc Thu Aug 21 15:08:21 2008 > @@ -86,13 +86,22 @@ > return list; > } > > -/* > + /* I don't really know how to implement these if they need something > + special, so I'll sort the sub list and defer processing to the > + ResizablePMCArray's VTABLE methods of the same names */ > VTABLE PMC *get_pmc_keyed(PMC *key) { > + PMC * list = Parrot_mmd_sort_manhattan(INTERP, SELF); This should be *list. > + if(PMC_IS_NULL(list)) There should be a space between if and the parentheses. > + Parrot_ex_throw_from_c_args(INTERP, NULL, 1, "No applicable > methods.\n"); If there's no appropriate EXCEPTION_* constant, we should add one for MMD (instead of 1). -- c