On Tue, Apr 14, 2009 at 05:17:08AM -0700, Will Coleda via RT wrote:
> On Tue Apr 14 01:44:39 2009, samm...@gmail.com wrote:
> > Hi,
> > 
> > I think this line is wrong:
> > line 47:  system(qw(svn checkout -r),  $required , qw(
> > https://svn.parrot.org/parrot/trunk parrot));
> > 
> > all qw should be removed, in my ubuntu, i think what' s happening is 
> it's
> > removing all the spaces, so I'm getting a bunch of error messages, i 
> think
> > this is better:
> > system("svn checkout -r" . $required . " " . "
> > https://svn.parrot.org/parrot/trunk parrot");
> > 
> > Regards,
> > Sam
> 
> Out of curiosity, what error messages are you getting?
> 
> BTW, this command looks right to me, passing a list to system() instead 
> of a string avoids shell escaping issues.

The original looks right to me too, as long as $required contains
a single file name and not a blank separated list.  (But that would
get treated instead as a single file name that had embedded blanks,
which is the opposite symptom to the original description.)

Reply via email to