On Mon, 21 Jun 2004, Leopold Toetsch wrote:
> Ion Alexandru Morega <[EMAIL PROTECTED]> wrote:
>
> > Hello, i'm new to this list and to parrot programming, so i decided to
> > start with something simple. I implemented a String PMC that is pretty
> > much complete, it compiles, but i haven't tested it yet. It would be
> > great if someone had a look at it, and later when i write some tests
> > i'll check in a patch. The .pmc is attached.
>
> Looks quite good. Some notes:
> - (you mentioned it) needs tests
> - "extends mmd_default" isn't needed anymore, we do MMD anyway
> - the patch duplicates a lot of PerlString's behaviour. So it would
> probably be best to:
> 1) rename perlstring.pmc -> string.pmc
> 2) create: pmclass PerlString extends String
> 3) then duplicate the differing functions namely the set_<type>_native
> funcs that morph a PerlString and don't in the String PMC.
Honestly I'm tempted to throw away all the Perl* PMC classes and redo
them. Some of that code's quite old and a lot of things have changed since
we started with them, and I think we may do well to just start fresh.
If the string class is OK (I'm stuck with a dead machine and backup mail
access, so it's tough to get a good look at it) then let's put it in and
we can fix things up as we go.
Dan
--------------------------------------"it's like this"-------------------
Dan Sugalski even samurai
[EMAIL PROTECTED] have teddy bears and even
teddy bears get drunk
