Re: Broken sql string?

[Dave Page]

�
<BLOCKQUOTE dir=ltr 
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; 
MARGIN-RIGHT: 0px">
  
  <FONT 
  face=Tahoma size=2>-----Original Message-----From: Mark A. Taff 
  [mailto:[EMAIL PROTECTED]] Sent: 19 February 2002 
  11:26To: Dave PageSubject: Broken sql 
  string?
  
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">Dave,
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
  style="mso-tab-count: 1">����������� 
  Query sql strings taken from my new sql hbx cause the display sub (from 
  the sql output form, now cannibalized) to break if the string contains 
  vbCRLF.� The string in question 
  might be "SELECT *" & vbCRLF & "FROM 
  addresses"
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�
  <FONT face=Arial color=black 
  size=2><SPAN 
  style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">The 
  code searches for " FROM " to locate the from clause.<SPAN 
  style="mso-spacerun: yes">� Should it be rewritten to allow for 
  CRLF before any of the tokens, or do we need to first parse the query string 
  for CRLF and replace them with single 
  spaces?
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt">�<SPAN 
class=345352312-19022002>Hi 
Mark,
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>Please post this sort of message to the pgadmin-hackers 
list so everyone knows what's going on :)
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>I guess you're talking about the behaviour of the HBX 
which won't colour the FROM if it follows a crlf (sorry, the talk of 
cannibalized frmSQLOutput threw me a bit)? If so, then yes, this is a bug. The 
problem with the HBX though, is that *many* hours of work and testing have been 
put into it to make it work as well as it does. We did have code that coloured 
better, however it's very slow. This was the major problem - if you pasted in 
20K of SQL, then you had to wait quite some time for it to 
colour.
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>In answer to you question though, no, we should not 
modify the user's input in any way. We used to replace crlf with spaces before 
sending queries to the server, which was all fine and dandy until someone 
complained that the PL/Perl function they wrote wouldn't work properly - because 
it had lost all it's crlfs!!! If you can fix the HBX, or write a better version 
though, that would be great.
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>�
<SPAN 
style="FONT-SIZE: 10pt; FONT-FAMILY: Arial; mso-bidi-font-size: 12.0pt"><SPAN 
class=345352312-19022002>Regards, 
Dave.