Thanks Dave. regards,
*Dhiraj Chawla* Senior Software Engineer EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +91-20-30589522 On Thu, Sep 26, 2013 at 2:37 PM, Dave Page <[email protected]> wrote: > Thanks, applied for 1.18.1+. > > On Tue, Sep 24, 2013 at 10:39 AM, Dhiraj Chawla > <[email protected]> wrote: > > Hi Dave, > > > > Please find the updated patch. I have moved the Event Triggers node > before > > the Extensions node in the treeview. I have also re-arranged the the > display > > options list to the best of my knowledge. Please review the patch and > let me > > know your thoughts on the same. > > > > regards, > > > > Dhiraj Chawla > > Senior Software Engineer > > EnterpriseDB Corporation > > The Enterprise PostgreSQL Company > > > > Phone: +91-20-30589522 > > > > > > On Mon, Sep 23, 2013 at 9:08 PM, Dave Page <[email protected]> wrote: > >> > >> Hi > >> > >> On Fri, Sep 20, 2013 at 1:13 PM, Dhiraj Chawla > >> <[email protected]> wrote: > >> > Hi Dave, > >> > > >> > The Event Triggers options is not listed in the browser view options > on > >> > the > >> > Settings dialog of pgAdmin, which would allow a user the hide/show the > >> > Event > >> > Triggers collection node. Attached is the patch that fixes this issue. > >> > > >> > Let me know your view on the same. > >> > >> Thanks, that works. However, I notice it's not in the right place. We > >> normally display the nodes alphabetically - so can you please move the > >> Event Triggers node in the treeview so it appears before Extensions > >> (which I believe would be correct)? > >> > >> Then, the position in the list on frmOptions should be corrected to > >> match. We list items there in the order they'd be seen in the > >> treeview, running down and across the logical hierarchy - which I > >> think means both Extensions and Event Triggers are in the wrong place > >> - they should probably be between Casts and Languages (though, looking > >> more closely, I think all the Foreign Table stuff is in the wrong > >> place too, so feel free to fix that as well)! > >> > >> Thanks! > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
