pgstat: Fix transactional stats dropping for indexes Because index creation does not go through heap_create_with_catalog() we didn't call pgstat_create_relation(), leading to index stats of a newly created realtion not getting dropped during rollback. To fix, move the pgstat_create_relation() to heap_create(), which indexes do use.
Similarly, because dropping an index does not go through heap_drop_with_catalog(), we didn't drop index stats when the transaction dropping an index committed. Here there's no convenient common path for indexes and relations, so index_drop() now calls pgstat_drop_relation(). Add tests for transactional index stats handling. Author: "Drouvot, Bertrand" <[email protected]> Reviewed-by: Andres Freund <[email protected]> Reviewed-by: Kyotaro Horiguchi <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch: 15-, like 8b1dccd37c71, which introduced the bug Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/43e496e242984320efcf42c51c1e2b379aa03344 Modified Files -------------- src/backend/catalog/heap.c | 6 +- src/backend/catalog/index.c | 3 + src/test/regress/expected/stats.out | 109 +++++++++++++++++++++++++++++++++++- src/test/regress/sql/stats.sql | 50 ++++++++++++++++- 4 files changed, 161 insertions(+), 7 deletions(-)
