From b467bc9b9eccd61f4c976abd243d0031a06012c0 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Fri, 29 Oct 2021 16:59:22 -0400 Subject: [PATCH 05/11] Change ThisTimeLineID to be 'static' rather than 'extern'. This means code outside xlog.c can no longer access it. Previous commits have removed most cases whre that was needed, and this commit cleans up the last few. In xlogfuncs.c, there are a couple of places that use ThisTimeLineID to obtain the current timeline; since the code can't run in recovery, use GetWALInsertionTimeLine() instead. And, in xlogarchive.c, XLogArchiveNotifySeg() needs to know the relevant timeline, so have the caller pass it as an additional argument. --- src/backend/access/transam/xlog.c | 4 ++-- src/backend/access/transam/xlogarchive.c | 6 ++++-- src/backend/access/transam/xlogfuncs.c | 6 ++++-- src/include/access/xlog.h | 2 -- src/include/access/xlogarchive.h | 2 +- 5 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 91ea1139d8..801175c177 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -192,7 +192,7 @@ CheckpointStatsData CheckpointStats; * ThisTimeLineID will be same in all backends --- it identifies current * WAL timeline for the database system. */ -TimeLineID ThisTimeLineID = 0; +static TimeLineID ThisTimeLineID = 0; static XLogRecPtr LastRec; @@ -2631,7 +2631,7 @@ XLogWrite(XLogwrtRqst WriteRqst, bool flexible) LogwrtResult.Flush = LogwrtResult.Write; /* end of page */ if (XLogArchivingActive()) - XLogArchiveNotifySeg(openLogSegNo); + XLogArchiveNotifySeg(openLogSegNo, ThisTimeLineID); XLogCtl->lastSegSwitchTime = (pg_time_t) time(NULL); XLogCtl->lastSegSwitchLSN = LogwrtResult.Flush; diff --git a/src/backend/access/transam/xlogarchive.c b/src/backend/access/transam/xlogarchive.c index 26b023e754..7d56dad0de 100644 --- a/src/backend/access/transam/xlogarchive.c +++ b/src/backend/access/transam/xlogarchive.c @@ -498,11 +498,13 @@ XLogArchiveNotify(const char *xlog) * Convenience routine to notify using segment number representation of filename */ void -XLogArchiveNotifySeg(XLogSegNo segno) +XLogArchiveNotifySeg(XLogSegNo segno, TimeLineID tli) { char xlog[MAXFNAMELEN]; - XLogFileName(xlog, ThisTimeLineID, segno, wal_segment_size); + Assert(tli != 0); + + XLogFileName(xlog, tli, segno, wal_segment_size); XLogArchiveNotify(xlog); } diff --git a/src/backend/access/transam/xlogfuncs.c b/src/backend/access/transam/xlogfuncs.c index 5bebcc50dd..dd9a45c186 100644 --- a/src/backend/access/transam/xlogfuncs.c +++ b/src/backend/access/transam/xlogfuncs.c @@ -469,7 +469,8 @@ pg_walfile_name_offset(PG_FUNCTION_ARGS) * xlogfilename */ XLByteToPrevSeg(locationpoint, xlogsegno, wal_segment_size); - XLogFileName(xlogfilename, ThisTimeLineID, xlogsegno, wal_segment_size); + XLogFileName(xlogfilename, GetWALInsertionTimeLine(), xlogsegno, + wal_segment_size); values[0] = CStringGetTextDatum(xlogfilename); isnull[0] = false; @@ -511,7 +512,8 @@ pg_walfile_name(PG_FUNCTION_ARGS) "pg_walfile_name()"))); XLByteToPrevSeg(locationpoint, xlogsegno, wal_segment_size); - XLogFileName(xlogfilename, ThisTimeLineID, xlogsegno, wal_segment_size); + XLogFileName(xlogfilename, GetWALInsertionTimeLine(), xlogsegno, + wal_segment_size); PG_RETURN_TEXT_P(cstring_to_text(xlogfilename)); } diff --git a/src/include/access/xlog.h b/src/include/access/xlog.h index 22f1d37fb2..51a672b703 100644 --- a/src/include/access/xlog.h +++ b/src/include/access/xlog.h @@ -29,8 +29,6 @@ #define SYNC_METHOD_OPEN_DSYNC 4 /* for O_DSYNC */ extern int sync_method; -extern PGDLLIMPORT TimeLineID ThisTimeLineID; /* current TLI */ - /* * Recovery target type. * Only set during a Point in Time recovery, not when in standby mode. diff --git a/src/include/access/xlogarchive.h b/src/include/access/xlogarchive.h index 3edd1a976c..7dcf1bd2dd 100644 --- a/src/include/access/xlogarchive.h +++ b/src/include/access/xlogarchive.h @@ -24,7 +24,7 @@ extern void ExecuteRecoveryCommand(const char *command, const char *commandName, bool failOnSignal); extern void KeepFileRestoredFromArchive(const char *path, const char *xlogfname); extern void XLogArchiveNotify(const char *xlog); -extern void XLogArchiveNotifySeg(XLogSegNo segno); +extern void XLogArchiveNotifySeg(XLogSegNo segno, TimeLineID tli); extern void XLogArchiveForceDone(const char *xlog); extern bool XLogArchiveCheckDone(const char *xlog); extern bool XLogArchiveIsBusy(const char *xlog); -- 2.24.3 (Apple Git-128)