From 2a31dd49ff313914f39b56756103031259c0fe80 Mon Sep 17 00:00:00 2001 From: Mingli Zhang Date: Tue, 26 Jul 2022 23:38:56 +0800 Subject: [PATCH vn] Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO. FORCE_NOT_NULL and FORCE_NULL are only used when COPY FROM. Remove unnecessary codes when COPY TO. --- src/backend/commands/copyto.c | 46 ----------------------------------- 1 file changed, 46 deletions(-) diff --git a/src/backend/commands/copyto.c b/src/backend/commands/copyto.c index fca29a9a10..64422ab9b9 100644 --- a/src/backend/commands/copyto.c +++ b/src/backend/commands/copyto.c @@ -591,52 +591,6 @@ BeginCopyTo(ParseState *pstate, } } - /* Convert FORCE_NOT_NULL name list to per-column flags, check validity */ - cstate->opts.force_notnull_flags = (bool *) palloc0(num_phys_attrs * sizeof(bool)); - if (cstate->opts.force_notnull) - { - List *attnums; - ListCell *cur; - - attnums = CopyGetAttnums(tupDesc, cstate->rel, cstate->opts.force_notnull); - - foreach(cur, attnums) - { - int attnum = lfirst_int(cur); - Form_pg_attribute attr = TupleDescAttr(tupDesc, attnum - 1); - - if (!list_member_int(cstate->attnumlist, attnum)) - ereport(ERROR, - (errcode(ERRCODE_INVALID_COLUMN_REFERENCE), - errmsg("FORCE_NOT_NULL column \"%s\" not referenced by COPY", - NameStr(attr->attname)))); - cstate->opts.force_notnull_flags[attnum - 1] = true; - } - } - - /* Convert FORCE_NULL name list to per-column flags, check validity */ - cstate->opts.force_null_flags = (bool *) palloc0(num_phys_attrs * sizeof(bool)); - if (cstate->opts.force_null) - { - List *attnums; - ListCell *cur; - - attnums = CopyGetAttnums(tupDesc, cstate->rel, cstate->opts.force_null); - - foreach(cur, attnums) - { - int attnum = lfirst_int(cur); - Form_pg_attribute attr = TupleDescAttr(tupDesc, attnum - 1); - - if (!list_member_int(cstate->attnumlist, attnum)) - ereport(ERROR, - (errcode(ERRCODE_INVALID_COLUMN_REFERENCE), - errmsg("FORCE_NULL column \"%s\" not referenced by COPY", - NameStr(attr->attname)))); - cstate->opts.force_null_flags[attnum - 1] = true; - } - } - /* Use client encoding when ENCODING option is not specified. */ if (cstate->opts.file_encoding < 0) cstate->file_encoding = pg_get_client_encoding(); -- 2.34.1