From ee38e2523a50f63e5183f0d262d9777d5f5efd24 Mon Sep 17 00:00:00 2001 From: Ranier Vilela Date: Fri, 7 Jul 2023 10:04:20 -0300 Subject: [PATCH] Standardize type of extend_by counter. The counter of extend_by loop is mixed by int and uint32. Fix by standardizing from int to uint32. To match limits of extend_by variable (uint32). --- src/backend/storage/buffer/bufmgr.c | 6 +++--- src/backend/storage/buffer/localbuf.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index a7e3b9bb1d..526ec0d265 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -955,7 +955,7 @@ ExtendBufferedRelTo(ExtendBufferedWhat eb, current_size = first_block + extended_by; Assert(num_pages != 0 || current_size >= extend_to); - for (int i = 0; i < extended_by; i++) + for (uint32 i = 0; i < extended_by; i++) { if (first_block + i != extend_to - 1) ReleaseBuffer(buffers[i]); @@ -1938,7 +1938,7 @@ ExtendBufferedRelShared(ExtendBufferedWhat eb, * This needs to happen before we extend the relation, because as soon as * we do, other backends can start to read in those pages. */ - for (int i = 0; i < extend_by; i++) + for (uint32 i = 0; i < extend_by; i++) { Buffer victim_buf = buffers[i]; BufferDesc *victim_buf_hdr = GetBufferDescriptor(victim_buf - 1); @@ -2070,7 +2070,7 @@ ExtendBufferedRelShared(ExtendBufferedWhat eb, io_start, extend_by); /* Set BM_VALID, terminate IO, and wake up any waiters */ - for (int i = 0; i < extend_by; i++) + for (uint32 i = 0; i < extend_by; i++) { Buffer buf = buffers[i]; BufferDesc *buf_hdr = GetBufferDescriptor(buf - 1); diff --git a/src/backend/storage/buffer/localbuf.c b/src/backend/storage/buffer/localbuf.c index f684862d98..a56e5ceb96 100644 --- a/src/backend/storage/buffer/localbuf.c +++ b/src/backend/storage/buffer/localbuf.c @@ -360,7 +360,7 @@ ExtendBufferedRelLocal(ExtendBufferedWhat eb, relpath(eb.smgr->smgr_rlocator, fork), MaxBlockNumber))); - for (int i = 0; i < extend_by; i++) + for (uint32 i = 0; i < extend_by; i++) { int victim_buf_id; BufferDesc *victim_buf_hdr; @@ -416,7 +416,7 @@ ExtendBufferedRelLocal(ExtendBufferedWhat eb, pgstat_count_io_op_time(IOOBJECT_TEMP_RELATION, IOCONTEXT_NORMAL, IOOP_EXTEND, io_start, extend_by); - for (int i = 0; i < extend_by; i++) + for (uint32 i = 0; i < extend_by; i++) { Buffer buf = buffers[i]; BufferDesc *buf_hdr; -- 2.32.0.windows.1