From d679aa38b5d7e828ac7eef4a239e9da3fbdc0704 Mon Sep 17 00:00:00 2001 From: Bharath Rupireddy Date: Mon, 30 Oct 2023 05:31:03 +0000 Subject: [PATCH v1] Add error case test for pg_stat_reset_shared with unknown stats type This commit adds an error case test for pg_stat_reset_shared with an unknown stats type to help with the code coverage a bit. --- src/test/regress/expected/stats.out | 4 ++++ src/test/regress/sql/stats.sql | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out index 32ad7f3dcc..53b632dcd3 100644 --- a/src/test/regress/expected/stats.out +++ b/src/test/regress/expected/stats.out @@ -991,6 +991,10 @@ SELECT stats_reset = :'wal_reset_ts'::timestamptz FROM pg_stat_wal; t (1 row) +-- Test error case for reset_shared with unknown stats type +SELECT pg_stat_reset_shared('unknown'); +ERROR: unrecognized reset target: "unknown" +HINT: Target must be "archiver", "bgwriter", "checkpointer", "io", "recovery_prefetch", or "wal". -- Test that reset works for pg_stat_database -- Since pg_stat_database stats_reset starts out as NULL, reset it once first so we have something to compare it to SELECT pg_stat_reset(); diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql index 8bfeed607f..febb83add0 100644 --- a/src/test/regress/sql/stats.sql +++ b/src/test/regress/sql/stats.sql @@ -489,6 +489,9 @@ SELECT stats_reset = :'bgwriter_reset_ts'::timestamptz FROM pg_stat_bgwriter; SELECT stats_reset = :'checkpointer_reset_ts'::timestamptz FROM pg_stat_checkpointer; SELECT stats_reset = :'wal_reset_ts'::timestamptz FROM pg_stat_wal; +-- Test error case for reset_shared with unknown stats type +SELECT pg_stat_reset_shared('unknown'); + -- Test that reset works for pg_stat_database -- Since pg_stat_database stats_reset starts out as NULL, reset it once first so we have something to compare it to -- 2.34.1