From 3ce445ef8bc9d47d8ad45757df8ca3bbc7f1aa78 Mon Sep 17 00:00:00 2001
From: Daniel Gustafsson <dgustafsson@postgresql.org>
Date: Fri, 1 Dec 2023 12:04:49 +0100
Subject: [PATCH v4 1/2] Drop global objects after completed test

Project policy is to not leave global objects behind after a regress
test run.
---
 .../modules/test_pg_dump/expected/test_pg_dump.out     |  9 +++++++++
 src/test/modules/test_pg_dump/sql/test_pg_dump.sql     | 10 ++++++++++
 2 files changed, 19 insertions(+)

diff --git a/src/test/modules/test_pg_dump/expected/test_pg_dump.out b/src/test/modules/test_pg_dump/expected/test_pg_dump.out
index f14f3a6664..479d7fc898 100644
--- a/src/test/modules/test_pg_dump/expected/test_pg_dump.out
+++ b/src/test/modules/test_pg_dump/expected/test_pg_dump.out
@@ -91,3 +91,12 @@ ALTER EXTENSION test_pg_dump DROP SERVER s0;
 ALTER EXTENSION test_pg_dump DROP TABLE test_pg_dump_t1;
 ALTER EXTENSION test_pg_dump DROP TYPE test_pg_dump_e1;
 ALTER EXTENSION test_pg_dump DROP VIEW test_pg_dump_v1;
+REVOKE USAGE ON FOREIGN SERVER s0 FROM regress_dump_test_role;
+REVOKE SELECT (c1) ON ft1 FROM regress_dump_test_role;
+REVOKE SELECT ON ft1 FROM regress_dump_test_role;
+REVOKE UPDATE ON test_pg_dump_mv1 FROM regress_dump_test_role;
+REVOKE USAGE ON SCHEMA test_pg_dump_s1 FROM regress_dump_test_role;
+REVOKE USAGE ON TYPE test_pg_dump_e1 FROM regress_dump_test_role;
+REVOKE EXECUTE ON FUNCTION test_pg_dump(int) FROM regress_dump_test_role;
+DROP EXTENSION test_pg_dump;
+DROP ROLE regress_dump_test_role;
diff --git a/src/test/modules/test_pg_dump/sql/test_pg_dump.sql b/src/test/modules/test_pg_dump/sql/test_pg_dump.sql
index a61a7c8c4c..164d6408ee 100644
--- a/src/test/modules/test_pg_dump/sql/test_pg_dump.sql
+++ b/src/test/modules/test_pg_dump/sql/test_pg_dump.sql
@@ -106,3 +106,13 @@ ALTER EXTENSION test_pg_dump DROP SERVER s0;
 ALTER EXTENSION test_pg_dump DROP TABLE test_pg_dump_t1;
 ALTER EXTENSION test_pg_dump DROP TYPE test_pg_dump_e1;
 ALTER EXTENSION test_pg_dump DROP VIEW test_pg_dump_v1;
+
+REVOKE USAGE ON FOREIGN SERVER s0 FROM regress_dump_test_role;
+REVOKE SELECT (c1) ON ft1 FROM regress_dump_test_role;
+REVOKE SELECT ON ft1 FROM regress_dump_test_role;
+REVOKE UPDATE ON test_pg_dump_mv1 FROM regress_dump_test_role;
+REVOKE USAGE ON SCHEMA test_pg_dump_s1 FROM regress_dump_test_role;
+REVOKE USAGE ON TYPE test_pg_dump_e1 FROM regress_dump_test_role;
+REVOKE EXECUTE ON FUNCTION test_pg_dump(int) FROM regress_dump_test_role;
+DROP EXTENSION test_pg_dump;
+DROP ROLE regress_dump_test_role;
-- 
2.32.1 (Apple Git-133)

