From 75ebdd659785a7a215cee93b5ae1e896dc98aea9 Mon Sep 17 00:00:00 2001 From: Alexander Korotkov Date: Wed, 3 Jul 2024 00:16:21 +0300 Subject: [PATCH v1 1/2] Fix typo in GetRunningTransactionData() e85662df44 made GetRunningTransactionData() calculate the oldest running transaction id within the current database. However, because of the typo, the new code uses oldestRunningXid instead of oldestDatabaseRunningXid in comparison before updating oldestDatabaseRunningXid. This commit fixes that issue. Reported-by: Noah Misch Discussion: https://postgr.es/m/20240630231816.bf.nmisch%40google.com Backpatch-through: 17 --- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 387b4a405b0..9fc930e98f8 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -2779,7 +2779,7 @@ GetRunningTransactionData(void) * Also, update the oldest running xid within the current database. */ if (proc->databaseId == MyDatabaseId && - TransactionIdPrecedes(xid, oldestRunningXid)) + TransactionIdPrecedes(xid, oldestDatabaseRunningXid)) oldestDatabaseRunningXid = xid; if (ProcGlobal->subxidStates[index].overflowed) -- 2.39.3 (Apple Git-145)