From 6bf0d618fd2fb6e5d4f042bcf0aadc182f5c9485 Mon Sep 17 00:00:00 2001 From: Amit Langote Date: Fri, 30 Aug 2024 12:10:09 +0900 Subject: [PATCH v2 1/4] Update comment about ExprState.escontext The updated comment provides more helpful guidance by mentioning that escontext should be set when soft error handling is needed. Reported-by: Jian He Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com --- src/include/nodes/execnodes.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index af7d8fd1e7..e4a4dcb029 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -132,8 +132,10 @@ typedef struct ExprState bool *innermost_domainnull; /* - * For expression nodes that support soft errors. Should be set to NULL - * before calling ExecInitExprRec() if the caller wants errors thrown. + * For expression nodes that support soft errors. Should be set to NULL if + * the caller wants errors to be thrown. Callers that do not want errors + * thrown should set it to a valid ErrorSaveContext before calling + * ExecInitExprRec(). */ ErrorSaveContext *escontext; } ExprState; -- 2.43.0