From c3459c9dcd024734c684458bec1113883ada06e0 Mon Sep 17 00:00:00 2001 From: ChangAo Chen Date: Mon, 24 Nov 2025 11:03:58 +0800 Subject: [PATCH v1] Use ROLERECURSE_PRIVS in is_admin_of_role(). Currently we use different role recurse methods in is_admin_of_role() and select_best_admin(), this could lead to an unexpected behavior. For example, when is_admin_of_role() return true, select_best_admin() can still return InvalidOid. To fix it, we use ROLERECURSE_PRIVS in is_admin_of_role(), making it consistent with select_best_admin(). --- src/backend/utils/adt/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c index fbcd64a2609..74fc73bc2be 100644 --- a/src/backend/utils/adt/acl.c +++ b/src/backend/utils/adt/acl.c @@ -5422,7 +5422,7 @@ is_admin_of_role(Oid member, Oid role) if (member == role) return false; - (void) roles_is_member_of(member, ROLERECURSE_MEMBERS, role, &admin_role); + (void) roles_is_member_of(member, ROLERECURSE_PRIVS, role, &admin_role); return OidIsValid(admin_role); } -- 2.34.1