From e9344980209f4fc6677c1a0bbed64c8190d66dc5 Mon Sep 17 00:00:00 2001 From: Man Zeng Date: Tue, 3 Feb 2026 14:44:31 +0800 Subject: [PATCH] Refactor AtEOXact_Buffers and AtEOXact_LocalBuffers to remove unnecessary parameters --- src/backend/access/transam/xact.c | 6 +++--- src/backend/postmaster/autovacuum.c | 2 +- src/backend/postmaster/bgwriter.c | 2 +- src/backend/postmaster/checkpointer.c | 2 +- src/backend/postmaster/walwriter.c | 2 +- src/backend/storage/buffer/bufmgr.c | 4 ++-- src/backend/storage/buffer/localbuf.c | 2 +- src/include/storage/buf_internals.h | 2 +- src/include/storage/bufmgr.h | 2 +- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index eba4f063168..60390383da2 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -2428,7 +2428,7 @@ CommitTransaction(void) AtEOXact_Aio(true); /* Check we've released all buffer pins */ - AtEOXact_Buffers(true); + AtEOXact_Buffers(); /* Clean up the relation cache */ AtEOXact_RelationCache(true); @@ -2736,7 +2736,7 @@ PrepareTransaction(void) AtEOXact_Aio(true); /* Check we've released all buffer pins */ - AtEOXact_Buffers(true); + AtEOXact_Buffers(); /* Clean up the relation cache */ AtEOXact_RelationCache(true); @@ -2988,7 +2988,7 @@ AbortTransaction(void) RESOURCE_RELEASE_BEFORE_LOCKS, false, true); AtEOXact_Aio(false); - AtEOXact_Buffers(false); + AtEOXact_Buffers(); AtEOXact_RelationCache(false); AtEOXact_TypeCache(); AtEOXact_Inval(false); diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c index 22379de1e31..b2d2ed928e6 100644 --- a/src/backend/postmaster/autovacuum.c +++ b/src/backend/postmaster/autovacuum.c @@ -478,7 +478,7 @@ AutoVacLauncherMain(const void *startup_data, size_t startup_data_len) /* this is probably dead code, but let's be safe: */ if (AuxProcessResourceOwner) ReleaseAuxProcessResources(false); - AtEOXact_Buffers(false); + AtEOXact_Buffers(); AtEOXact_SMgr(); AtEOXact_Files(false); AtEOXact_HashTables(false); diff --git a/src/backend/postmaster/bgwriter.c b/src/backend/postmaster/bgwriter.c index 80e3088fc7e..f867268b8b6 100644 --- a/src/backend/postmaster/bgwriter.c +++ b/src/backend/postmaster/bgwriter.c @@ -172,7 +172,7 @@ BackgroundWriterMain(const void *startup_data, size_t startup_data_len) pgaio_error_cleanup(); UnlockBuffers(); ReleaseAuxProcessResources(false); - AtEOXact_Buffers(false); + AtEOXact_Buffers(); AtEOXact_SMgr(); AtEOXact_Files(false); AtEOXact_HashTables(false); diff --git a/src/backend/postmaster/checkpointer.c b/src/backend/postmaster/checkpointer.c index 6482c21b8f9..250b37dd461 100644 --- a/src/backend/postmaster/checkpointer.c +++ b/src/backend/postmaster/checkpointer.c @@ -296,7 +296,7 @@ CheckpointerMain(const void *startup_data, size_t startup_data_len) pgaio_error_cleanup(); UnlockBuffers(); ReleaseAuxProcessResources(false); - AtEOXact_Buffers(false); + AtEOXact_Buffers(); AtEOXact_SMgr(); AtEOXact_Files(false); AtEOXact_HashTables(false); diff --git a/src/backend/postmaster/walwriter.c b/src/backend/postmaster/walwriter.c index 38ec8a4c8c7..8e1d9ebc598 100644 --- a/src/backend/postmaster/walwriter.c +++ b/src/backend/postmaster/walwriter.c @@ -168,7 +168,7 @@ WalWriterMain(const void *startup_data, size_t startup_data_len) pgaio_error_cleanup(); UnlockBuffers(); ReleaseAuxProcessResources(false); - AtEOXact_Buffers(false); + AtEOXact_Buffers(); AtEOXact_SMgr(); AtEOXact_Files(false); AtEOXact_HashTables(false); diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 7241477cac0..9b02bed5951 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -4100,11 +4100,11 @@ SyncOneBuffer(int buf_id, bool skip_recently_used, WritebackContext *wb_context) * cross-check that no pins remain. */ void -AtEOXact_Buffers(bool isCommit) +AtEOXact_Buffers(void) { CheckForBufferLeaks(); - AtEOXact_LocalBuffers(isCommit); + AtEOXact_LocalBuffers(); Assert(PrivateRefCountOverflowed == 0); } diff --git a/src/backend/storage/buffer/localbuf.c b/src/backend/storage/buffer/localbuf.c index 04a540379a2..9eab648256b 100644 --- a/src/backend/storage/buffer/localbuf.c +++ b/src/backend/storage/buffer/localbuf.c @@ -1000,7 +1000,7 @@ CheckForLocalBufferLeaks(void) * This is just like AtEOXact_Buffers, but for local buffers. */ void -AtEOXact_LocalBuffers(bool isCommit) +AtEOXact_LocalBuffers(void) { CheckForLocalBufferLeaks(); } diff --git a/src/include/storage/buf_internals.h b/src/include/storage/buf_internals.h index 27f12502d19..cbd66b0065a 100644 --- a/src/include/storage/buf_internals.h +++ b/src/include/storage/buf_internals.h @@ -608,6 +608,6 @@ extern void DropRelationLocalBuffers(RelFileLocator rlocator, ForkNumber *forkNum, int nforks, BlockNumber *firstDelBlock); extern void DropRelationAllLocalBuffers(RelFileLocator rlocator); -extern void AtEOXact_LocalBuffers(bool isCommit); +extern void AtEOXact_LocalBuffers(void); #endif /* BUFMGR_INTERNALS_H */ diff --git a/src/include/storage/bufmgr.h b/src/include/storage/bufmgr.h index a40adf6b2a8..265d376f994 100644 --- a/src/include/storage/bufmgr.h +++ b/src/include/storage/bufmgr.h @@ -281,7 +281,7 @@ extern Buffer ExtendBufferedRelTo(BufferManagerRelation bmr, ReadBufferMode mode); extern void InitBufferManagerAccess(void); -extern void AtEOXact_Buffers(bool isCommit); +extern void AtEOXact_Buffers(void); #ifdef USE_ASSERT_CHECKING extern void AssertBufferLocksPermitCatalogRead(void); #endif -- 2.45.2