From bc6c0fdda7eadd2fbbbcca4dac626f36dd22bf87 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 5 Dec 2018 17:18:26 +0100 Subject: [PATCH] Ensure to end errhint and errdetail with a period As per the Error Message Style Guide. --- contrib/amcheck/verify_nbtree.c | 2 +- src/backend/commands/tablecmds.c | 2 +- src/backend/utils/adt/jsonfuncs.c | 4 ++-- src/backend/utils/misc/guc.c | 6 +++--- src/pl/plpgsql/src/pl_exec.c | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c index a1438a2855..14ed31753f 100644 --- a/contrib/amcheck/verify_nbtree.c +++ b/contrib/amcheck/verify_nbtree.c @@ -294,7 +294,7 @@ btree_index_checkable(Relation rel) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("cannot check index \"%s\"", RelationGetRelationName(rel)), - errdetail("Index is not valid"))); + errdetail("Index is not valid."))); } /* diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 843ed48aa7..8e854279d2 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -11382,7 +11382,7 @@ ATExecAddInherit(Relation child_rel, RangeVar *parent, LOCKMODE lockmode) (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), errmsg("trigger \"%s\" prevents table \"%s\" from becoming an inheritance child", trigger_name, RelationGetRelationName(child_rel)), - errdetail("ROW triggers with transition tables are not supported in inheritance hierarchies"))); + errdetail("ROW triggers with transition tables are not supported in inheritance hierarchies."))); /* OK to create inheritance */ CreateInheritance(child_rel, parent_rel); diff --git a/src/backend/utils/adt/jsonfuncs.c b/src/backend/utils/adt/jsonfuncs.c index 1d63abc11b..fc1581c92b 100644 --- a/src/backend/utils/adt/jsonfuncs.c +++ b/src/backend/utils/adt/jsonfuncs.c @@ -4993,7 +4993,7 @@ parse_jsonb_index_flags(Jsonb *jb) ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE), errmsg("flag array element is not a string"), - errhint("Possible values are: \"string\", \"numeric\", \"boolean\", \"key\", and \"all\""))); + errhint("Possible values are: \"string\", \"numeric\", \"boolean\", \"key\", and \"all\"."))); if (v.val.string.len == 3 && pg_strncasecmp(v.val.string.val, "all", 3) == 0) @@ -5015,7 +5015,7 @@ parse_jsonb_index_flags(Jsonb *jb) (errcode(ERRCODE_INVALID_PARAMETER_VALUE), errmsg("wrong flag in flag array: \"%s\"", pnstrdup(v.val.string.val, v.val.string.len)), - errhint("Possible values are: \"string\", \"numeric\", \"boolean\", \"key\", and \"all\""))); + errhint("Possible values are: \"string\", \"numeric\", \"boolean\", \"key\", and \"all\"."))); } /* expect end of array now */ diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 03594e77fe..f8dd3b5b3f 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -10929,7 +10929,7 @@ check_effective_io_concurrency(int *newval, void **extra, GucSource source) #else if (*newval != 0) { - GUC_check_errdetail("effective_io_concurrency must be set to 0 on platforms that lack posix_fadvise()"); + GUC_check_errdetail("effective_io_concurrency must be set to 0 on platforms that lack posix_fadvise()."); return false; } return true; @@ -11041,7 +11041,7 @@ check_recovery_target_timeline(char **newval, void **extra, GucSource source) strtoul(*newval, NULL, 0); if (errno == EINVAL || errno == ERANGE) { - GUC_check_errdetail("recovery_target_timeline is not a valid number"); + GUC_check_errdetail("recovery_target_timeline is not a valid number."); return false; } rttg = RECOVERY_TARGET_TIMELINE_NUMERIC; @@ -11219,7 +11219,7 @@ check_recovery_target_name(char **newval, void **extra, GucSource source) /* Use the value of newval directly */ if (strlen(*newval) >= MAXFNAMELEN) { - GUC_check_errdetail("recovery_target_name is too long (maximum %d characters)", + GUC_check_errdetail("recovery_target_name is too long (maximum %d characters).", MAXFNAMELEN - 1); return false; } diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c index 39ea925820..1e0617322b 100644 --- a/src/pl/plpgsql/src/pl_exec.c +++ b/src/pl/plpgsql/src/pl_exec.c @@ -4232,7 +4232,7 @@ exec_stmt_execsql(PLpgSQL_execstate *estate, (errcode(ERRCODE_TOO_MANY_ROWS), errmsg("query returned more than one row"), errdetail ? errdetail_internal("parameters: %s", errdetail) : 0, - errhint("Make sure the query returns a single row, or use LIMIT 1"))); + errhint("Make sure the query returns a single row, or use LIMIT 1."))); } /* Put the first result row into the target */ exec_move_row(estate, target, tuptab->vals[0], tuptab->tupdesc); -- 2.14.1.145.gb3622a4ee