From d4d9d2dee145cafccc286093d0c3c8e5c68622e7 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Thu, 23 Apr 2020 10:43:04 +0530 Subject: [PATCH] Change the display of WAL usage statistics in Explain. In commit 33e05f89c5, we have added the option to display WAL usage statistics in Explain and auto_explain. The display format used two spaces between each field which is inconsistent with Buffer usage statistics which is using one space between each field. Change the format to make WAL usage statistics consistent with Buffer usage statistics. Author: Julien Rouhaud, Amit Kapila Reviewed-by: Justin Pryzby, Kyotaro Horiguchi and Amit Kapila Discussion: https://postgr.es/m/CAB-hujrP8ZfUkvL5OYETipQwA=e3n7oqHFU=4ZLxWS_Cza3kQQ@mail.gmail.com --- doc/src/sgml/ref/explain.sgml | 4 ++-- src/backend/commands/explain.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/src/sgml/ref/explain.sgml b/doc/src/sgml/ref/explain.sgml index aedd70a..e5b50d3 100644 --- a/doc/src/sgml/ref/explain.sgml +++ b/doc/src/sgml/ref/explain.sgml @@ -198,8 +198,8 @@ ROLLBACK; Include information on WAL record generation. Specifically, include the - number of records, number of full page writes and amount of WAL bytes - generated. In text format, only non-zero values are printed. This + number of records, number of full page writes (fpw) and amount of WAL + bytes generated. In text format, only non-zero values are printed. This parameter may only be used when ANALYZE is also enabled. It defaults to FALSE. diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c index 7ae6131..cfd0df3 100644 --- a/src/backend/commands/explain.c +++ b/src/backend/commands/explain.c @@ -3350,24 +3350,24 @@ show_wal_usage(ExplainState *es, const WalUsage *usage) appendStringInfoString(es->str, "WAL:"); if (usage->wal_records > 0) - appendStringInfo(es->str, " records=%ld", + appendStringInfo(es->str, " records=%ld", usage->wal_records); if (usage->wal_fpw > 0) - appendStringInfo(es->str, " full page writes=%ld", + appendStringInfo(es->str, " fpw=%ld", usage->wal_fpw); if (usage->wal_bytes > 0) - appendStringInfo(es->str, " bytes=" UINT64_FORMAT, + appendStringInfo(es->str, " bytes=" UINT64_FORMAT, usage->wal_bytes); appendStringInfoChar(es->str, '\n'); } } else { - ExplainPropertyInteger("WAL records", NULL, + ExplainPropertyInteger("WAL Records", NULL, usage->wal_records, es); - ExplainPropertyInteger("WAL full page writes", NULL, + ExplainPropertyInteger("WAL FPW", NULL, usage->wal_fpw, es); - ExplainPropertyUInteger("WAL bytes", NULL, + ExplainPropertyUInteger("WAL Bytes", NULL, usage->wal_bytes, es); } } -- 1.8.3.1