On Tue, 4 Dec 2018 17:36:18 +0100 Maarten Lankhorst <maarten.lankho...@linux.intel.com> wrote:
> Hey, > > Op 03-12-2018 om 16:01 schreef Basile Clement: > > > > This is essentially a duplicate of the recent patch by Maarten > > Lankhorst (which spurred me into finally posting these, which laid > > on my laptop for a couple months), with a slightly different > > approach. It is mostly included as it is a prerequisite for the > > subsequent patches, but they should work just as well with > > Maarten's patch. > > > > This series of patches is driven by a discussion with Marc > > Jeanmougin and the need of having dithering in pixman for inkscape, > > and tries to implement the recommendations given by Soren in > > previous threads on the topic. > Series looks sane, 1/4 is cleaner than my version. I would change Bpp > to cpp, or multiply by 8, since Bpp usually means bits per pixel. And cpp means channels-per-pixel? B usually means bytes, b often means bits. But not always, so you can never assume. I'd just write out bits_per_pixel or bytes_per_pixel, just like pitch_bytes or stride_pixels or stride_uint32s or whatever makes it totally obvious. 2c, thanks, pq
pgpZbUEJjLCuJ.pgp
Description: OpenPGP digital signature
_______________________________________________ Pixman mailing list Pixman@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pixman