----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/313/#review305 -----------------------------------------------------------
Ship it! yes, down with svg proliferation =) /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp <http://reviewboard.vidsolbach.de/r/313/#comment254> should this still be there? /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp <http://reviewboard.vidsolbach.de/r/313/#comment253> looks like we need a setAlignment method in Plasma::Label? =) - Aaron On 2008-12-23 10:01:25, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/313/ > ----------------------------------------------------------- > > (Updated 2008-12-23 10:01:25) > > > Review request for Plasma. > > > Summary > ------- > > This makes the job viewer extenderitem in the systemtray to use just the > standard scrollbar widget instead of a custom one and layouts and plasma > labels to display the info. > I think it's a pretty important thing to not make custom svg widget > proliferate, otherwise theming will become a real mess (a different scrollbar > for each possible label disposition would be really bad). > and a thing like that should be done like now or never :) > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp > > Diff: http://reviewboard.vidsolbach.de/r/313/diff > > > Testing > ------- > > tried to start some jobs, it seems to both look and behave in the exact way > as before > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel