> On Oct. 14, 2014, 1:50 p.m., Martin Gräßlin wrote:
> > -2, it's not installed as the WaylandServer still needs work and is not in 
> > a state yet to provide ABI.
> 
> Sebastian Kügler wrote:
>     Well, neither is WaylandServer, the point at this point in time is to 
> allow sharing code, no?
>     
>     Is there another way to easily start a wayland server to I can run my 
> autotests automatically?
> 
> Martin Gräßlin wrote:
>     that's why WaylandServer is not installed. The WaylandClient library is 
> supposed to be ABI stable.
>     
>     I want to get it into a state that WaylandServer can be ABI stable. But I 
> cannot guarantee that I will be happy with the state for 5.1. It pretty much 
> depends on how fast we get the interfaces implemented. At the moment lots is 
> still stubs which makes it difficult to say "yeah, that API won't change 
> anymore".
>     
>     For your current need I'd suggest to keep the patch locally to get it 
> working and make proper CMake magic in kscreen. AFAIU you only need the 
> server for the unit test, so the component should only be searched for tests 
> and the respective tests should just not be built if the Component is not 
> found. That way you should be able to write all the tests and they will just 
> work (TM) once this component becomes public.

As you submitted part of the change I read that as the suggestion works for you?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120579/#review68383
-----------------------------------------------------------


On Oct. 14, 2014, 2:49 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120579/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 2:49 p.m.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> Install headers for WaylandServer
> 
> I'm not sure why this was commented (it didn't work, due to wrong
> paths), but maybe there's another reason.
> 
> Anyway, I'd like to use these things for my unit tests in libkscreen, so
> I don't have to start a Wayland server manually, and this seems to be
> needed.
> 
> In detail:
> - actually install headers
> - generate the export header into Wayland/Server
> - include it from there
> 
> 
> Diffs
> -----
> 
>   src/server/CMakeLists.txt 066d564507633b42455482b441912359d7e65c74 
>   src/server/buffer_interface.h 9cf84c5f3b62df6d53c36d4671302388a9adf261 
>   src/server/compositor_interface.h 60ea01a59cea595df39d5ab74215f2de98fb390d 
>   src/server/display.h 31cb24fc46576e94e72e637a81b99b8155fcbe9b 
>   src/server/output_interface.h eba9a32e5110a6892931665ff568e4322cd1c8e1 
>   src/server/seat_interface.h 18d2dba38564df0519cd6f636f2dc527473c0b97 
>   src/server/shell_interface.h 31f84044c7dcfb172e6a8a7134f9474ff973c5fd 
>   src/server/surface_interface.h 31e0e75e3db534720900cf4458ea1c265f5570a7 
> 
> Diff: https://git.reviewboard.kde.org/r/120579/diff/
> 
> 
> Testing
> -------
> 
> Used the library from libkscreen, no problems so far (headers found, linker 
> succeeds).
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to