> On Oct. 31, 2015, 5:33 p.m., Thomas Pfeiffer wrote:
> > Thanks for adding usability!
> > I agree with Kai that the whole header area should be scrollable instead of 
> > just the label.
> > One thing to make sure (if that is even affected by this change at all) is 
> > that when we have events in the poup, scrolling over the even description 
> > won't change the month.
> > 
> > Other than that, +1 for the change!

This change makes the entire component (header + calendar view) scrollable.

> scrolling over the event description won't change the month.

Of course, but the code isn't there yet (at least I can't find it :).


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125891/#review87784
-----------------------------------------------------------


On Oct. 31, 2015, 4:21 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125891/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 4:21 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Allow to scroll navigate back/forward in DaysCalendar in the entire 
> DaysCalendar component, not just on header label.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml a1d84d4 
> 
> Diff: https://git.reviewboard.kde.org/r/125891/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Rosca
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to