davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY The rationale is two-fold: 1. It fixes a security issue. Right now, a rogue app can killall kde-policykit-agent-1 and register a new authentication agent. Next time a user gets asked for a password, they get prompted by the rogue app. If KSMServer quits or doesn't start, the plasma session quits or doesn't start. 2. It's a boot speed-up. Registering a few things in KSMServer is a lot quicker and lighter than spawning a whole extra QApplication binary. --- PolicyKit agent has been imported with the usual: git filter-branch to move into a subdir, then add as a remote of p-w, then merge. Though given it's literally only 3 classes, I'm not sure the mess is worth it. Messages.sh file moved with the translation context the same. So it should be headache free for translators (hopefully!) --- Files changed in policykit-agent are polkitkde.* and it no longer installs a .desktop file into the autostart folder. TEST PLAN Logged in Didn't run the process pkexec showed the right dialog qdbus into ksmserver whilst the dialog is open shows ksmserver isn't blocked REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D8924 AFFECTED FILES CMakeLists.txt ksmserver/CMakeLists.txt ksmserver/config.h.cmake ksmserver/main.cpp ksmserver/policykit-agent/AuthDialog.cpp ksmserver/policykit-agent/AuthDialog.h ksmserver/policykit-agent/AuthDialog.ui ksmserver/policykit-agent/CMakeLists.txt ksmserver/policykit-agent/COPYING ksmserver/policykit-agent/Messages.sh ksmserver/policykit-agent/authdetails.ui ksmserver/policykit-agent/org.freedesktop.PolicyKit.AuthenticationAgent.xml ksmserver/policykit-agent/org.kde.Polkit1AuthAgent.xml ksmserver/policykit-agent/policykit1-kde.notifyrc ksmserver/policykit-agent/policykitkde.cpp ksmserver/policykit-agent/policykitkde.h ksmserver/policykit-agent/policykitlistener.cpp ksmserver/policykit-agent/policykitlistener.h To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart