I'm finding it difficult to have the regression test and also the NOTICE in isvalid and also have the differential behaviour for different versions of GEOS. One is going to have to go. I can't ensure the "reason" I provide in my short circuit to match the reason GEOS is going to give.
On Thu, May 26, 2011 at 11:00 PM, Sandro Santilli <s...@keybit.net> wrote: > On Thu, May 26, 2011 at 11:46:34AM -0700, Paul Ramsey wrote: >> Like so? >> >> http://trac.osgeo.org/postgis/attachment/ticket/987/inf2.patch > > A few points: > > 1: GEOS-driven ST_IsValid raises a NOTICE containing the reason, home-made > version should do the same. > 2: I see you're not handling nan, just infinite. Is that intentional ? > 3: GEOS-3.2 also survive the inf/nans in GEOSValid, why checkin for 3.3+ ? > 4: Expecting the error in tickets.sql makes the whole test file > pass or fail based on the version of GEOS you built postgis against. > > --strk; > > () Free GIS & Flash consultant/developer > /\ http://strk.keybit.net/services.html > _______________________________________________ > postgis-users mailing list > postgis-users@postgis.refractions.net > http://postgis.refractions.net/mailman/listinfo/postgis-users > _______________________________________________ postgis-users mailing list postgis-users@postgis.refractions.net http://postgis.refractions.net/mailman/listinfo/postgis-users
