https://github.com/python/cpython/commit/21c09d9f8195433f34b72ddfa25dd1bda3019ed7
commit: 21c09d9f8195433f34b72ddfa25dd1bda3019ed7
branch: main
author: da-woods <[email protected]>
committer: hauntsaninja <[email protected]>
date: 2024-05-01T01:33:28-07:00
summary:

Test syntax error on comma-less tuple-style sequence patterns (#115485)

Adds a test that length-1 tuple-style sequence patterns must end in a comma, 
since there isn't currently one.

Spotted while reviewing Cython's proposed implementation of the pattern 
matching syntax 
(https://github.com/cython/cython/pull/4897#discussion_r1489177169) where there 
was a bug my the reimplementation that wasn't caught against the CPython tests 
here.

files:
M Lib/test/test_patma.py

diff --git a/Lib/test/test_patma.py b/Lib/test/test_patma.py
index 298e78ccee3875..1bdab125dc6ef0 100644
--- a/Lib/test/test_patma.py
+++ b/Lib/test/test_patma.py
@@ -2957,6 +2957,14 @@ def test_invalid_syntax_3(self):
                 pass
         """)
 
+    def test_len1_tuple_sequence_pattern_comma(self):
+        # correct syntax would be `case(*x,):`
+        self.assert_syntax_error("""
+        match ...:
+            case (*x):
+                pass
+        """)
+
     def 
test_mapping_pattern_keys_may_only_match_literals_and_attribute_lookups(self):
         self.assert_syntax_error("""
         match ...:

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to