https://github.com/python/cpython/commit/67f5c5bd6fcc956a785edef3be67e8cbe470cd31
commit: 67f5c5bd6fcc956a785edef3be67e8cbe470cd31
branch: main
author: Taneli Hukkinen <[email protected]>
committer: encukou <[email protected]>
date: 2024-10-29T11:36:14+01:00
summary:

tomllib: Add a comment about implicit lru_cache bound (GH-126078)

files:
M Lib/tomllib/_re.py

diff --git a/Lib/tomllib/_re.py b/Lib/tomllib/_re.py
index 994bb7493fd928..9eacefc729544e 100644
--- a/Lib/tomllib/_re.py
+++ b/Lib/tomllib/_re.py
@@ -84,6 +84,9 @@ def match_to_datetime(match: re.Match) -> datetime | date:
     return datetime(year, month, day, hour, minute, sec, micros, tzinfo=tz)
 
 
+# No need to limit cache size. This is only ever called on input
+# that matched RE_DATETIME, so there is an implicit bound of
+# 24 (hours) * 60 (minutes) * 2 (offset direction) = 2880.
 @lru_cache(maxsize=None)
 def cached_tz(hour_str: str, minute_str: str, sign_str: str) -> timezone:
     sign = 1 if sign_str == "+" else -1

_______________________________________________
Python-checkins mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/python-checkins.python.org/
Member address: [email protected]

Reply via email to